Conversation
prownd
commented
Sep 20, 2026
prownd
commented
- cJSON_Utils.c: '#ifdef GNUCC' is never defined, so the visibility pragmas around the system headers were dead code; use GNUC.
- cJSON_Utils.c: remove duplicated <math.h> include and a stray ';;'.
- cJSON.c: parenthesize the arguments of the fallback isnan/isinf macros and the fallback NAN definitions.
- cJSON.h: parenthesize macro arguments of cJSON_SetNumberValue, cJSON_SetBoolValue and cJSON_ArrayForEach, so that expressions such as cJSON_SetNumberValue(flag ? a : b, x) expand correctly.
- cJSON.c: make the internal helper cJSON_Duplicate_rec static, it was exported without being declared in cJSON.h.
- Fix wrong/misspelled comments: UTF-8 four byte lead mask, 'to deeply', 'cinput', 'it's elements', 'Minify a strings', 'rejects to parse', RFC7386 -> RFC7396, 'overwrite and existing', 'paring numbers', 'mainfest'.
* cJSON_Utils.c: '#ifdef __GNUCC__' is never defined, so the visibility pragmas around the system headers were dead code; use __GNUC__. * cJSON_Utils.c: remove duplicated <math.h> include and a stray ';;'. * cJSON.c: parenthesize the arguments of the fallback isnan/isinf macros and the fallback NAN definitions. * cJSON.h: parenthesize macro arguments of cJSON_SetNumberValue, cJSON_SetBoolValue and cJSON_ArrayForEach, so that expressions such as cJSON_SetNumberValue(flag ? a : b, x) expand correctly. * cJSON.c: make the internal helper cJSON_Duplicate_rec static, it was exported without being declared in cJSON.h. * Fix wrong/misspelled comments: UTF-8 four byte lead mask, 'to deeply', 'cinput', 'it's elements', 'Minify a strings', 'rejects to parse', RFC7386 -> RFC7396, 'overwrite and existing', 'paring numbers', 'mainfest'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.