Skip to content

fix(digest): Run Now uses hybrid personalized path - #109

Merged
venkateshsakamuri-lab merged 2 commits into
mainfrom
cursor/digest-trigger-hybrid
Sep 10, 2026
Merged

fix(digest): Run Now uses hybrid personalized path#109
venkateshsakamuri-lab merged 2 commits into
mainfrom
cursor/digest-trigger-hybrid

Conversation

@venkateshsakamuri-lab

Copy link
Copy Markdown
Contributor

Summary

  • Wire admin Run Now / POST /api/admin/slack/digest/trigger through sendDailyDigestAsync()sendDailyDigestHybrid() (per-user prefs / Slack DMs when present; legacy broadcast otherwise) instead of legacy-only sendDailyDigest().
  • Keep trigger response messaging honest: when prefs exist, mention personalized DMs and that channel bindings are not required for DMs.
  • Add focused unit tests in DigestTriggerHybridTest.

Stayflexi GTM needs Run Now to DM per-user prefs (e.g. EXEC on ec2-replica). Tiny follow-up; does not mix with Digests prefs UX (#108).

Test plan

  • ./mvnw -Dtest=DigestTriggerHybridTest test
  • Admin Digests → Run Now with per-user prefs and no channel bindings → personalized DM path runs; toast does not claim “only appear in the app”
  • Legacy (no prefs) with no bindings → prior channel-binding message still shown

Wire sendDailyDigestAsync (used by POST /api/admin/slack/digest/trigger)
to sendDailyDigestHybrid so Stayflexi GTM Run Now DMs per-user prefs
instead of legacy channel-only broadcast. Honest trigger messages when
prefs exist (DMs do not require channel bindings).
@venkateshsakamuri-lab
venkateshsakamuri-lab requested a review from a team as a code owner September 10, 2026 04:59
@venkateshsakamuri-lab
venkateshsakamuri-lab merged commit 38ad33a into main Sep 10, 2026
9 checks passed
@venkateshsakamuri-lab
venkateshsakamuri-lab deleted the cursor/digest-trigger-hybrid branch September 10, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant