Keep Tool Configuration credentials out of the edit form - #15624
Open
svader0 wants to merge 1 commit into
Open
Conversation
The edit view decrypted the stored password and ssh key on GET and the form bound all three credential fields with their values, so anyone permitted to edit a tool configuration could read the credentials it holds. The Django admin form for the same model already masks these fields. Stop sending the stored values to the browser and treat a blank submission as "unchanged" on save, which also fixes clearing a credential by saving the form without re-entering it. The stored value is only reused while the URL is unchanged, so a credential is never paired with a destination supplied in the same request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening / consistency improvement to the Tool Configuration edit form. Stored credential values are no longer sent back to the browser, matching what the Django admin form for the same model already does, and an omitted value on save is treated as unchanged rather than cleared. That second part also fixes a small data-loss bug: saving the form today without re-entering the credential wipes it.
Adds a regression test. No functional change for correctly-permissioned users.