Skip to content

fix(mcp): reject stale AST coordinates after source changes - #2105

Open
lorenzozanee wants to merge 2 commits into
DeusData:mainfrom
lorenzozanee:fix/1750-stale-ast-coordinates
Open

fix(mcp): reject stale AST coordinates after source changes#2105
lorenzozanee wants to merge 2 commits into
DeusData:mainfrom
lorenzozanee:fix/1750-stale-ast-coordinates

Conversation

@lorenzozanee

@lorenzozanee lorenzozanee commented Sep 8, 2026

Copy link
Copy Markdown

Fixes #1750. Source edits can invalidate AST line ranges, so this update uses the canonical file metadata on Windows before exposing stored coordinates, rejects stale snippet reads, and preserves raw search matches without stale AST attribution.

Signed-off-by: lorenzozanee <wyz0707@proton.me>
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

Signed-off-by: lorenzozanee <wyz0707@proton.me>
@DeusData DeusData added bug Something isn't working parsing/quality Graph extraction bugs, false positives, missing edges windows Windows-specific issues priority/high Needs near-term maintainer attention; high-impact bug, regression, safety issue, or release blocker. labels Sep 9, 2026
@DeusData

DeusData commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Thank you for addressing stale AST coordinates and including coverage in tests/test_mcp.c. This is queued as a high-priority correctness fix. We need more time to review the source-change checks and their behavior across the snippet/outline paths before giving a decision.

The review queue is currently full, so detailed feedback may take a little time. We are working through it carefully and appreciate the work you have put into supporting the project. Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working parsing/quality Graph extraction bugs, false positives, missing edges priority/high Needs near-term maintainer attention; high-impact bug, regression, safety issue, or release blocker. windows Windows-specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Stale AST line coordinates in get_code_snippet / search_code after file modification

2 participants