Skip to content

remove inlines form react gantt demos #35142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DuckTieCorpMember wants to merge 2 commits into
base: feature/react-inline-eslint-rules
Choose a base branch
from
Open

remove inlines form react gantt demos #35142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eaec2f
remove inlines form react gantt demos
DuckTieCorpMember Sep 10, 2026
4228aaa
restore line endings
DuckTieCorpMember Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions apps/demos/Demos/Gantt/Appearance/React/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, { useCallback, useState } from 'react';
import Gantt, {
Tasks, Dependencies, Resources, ResourceAssignments, Column, Editing,
} from 'devextreme-react/gantt';
Expand Down Expand Up @@ -35,17 +35,19 @@ const initialGanttConfig = {

function App() {
const [ganttConfig, setGanttConfig] = useState(initialGanttConfig);
const updateGanttConfig = (value: Partial<typeof initialGanttConfig>) => setGanttConfig({
...ganttConfig,
...value,
});
const onScaleTypeChanged: ISelectBoxOptions['onValueChanged'] = ({ value }) => updateGanttConfig({ scaleType: value });
const onTaskTitlePositionChanged: ISelectBoxOptions['onValueChanged'] = ({ value }) => updateGanttConfig({ taskTitlePosition: value });
const onShowResourcesChanged: ICheckBoxOptions['onValueChanged'] = ({ value }) => updateGanttConfig({ showResources: value });
const onShowDependenciesChanged: ICheckBoxOptions['onValueChanged'] = ({ value }) => updateGanttConfig({ showDependencies: value });
const onShowCustomTaskTooltip: ICheckBoxOptions['onValueChanged'] = ({ value }) => updateGanttConfig({ showCustomTaskTooltip: value });
const onStartDateValueChanged: IDateBoxOptions['onValueChanged'] = ({ value }) => updateGanttConfig({ startDateRange: value });
const onEndDateValueChanged: IDateBoxOptions['onValueChanged'] = ({ value }) => updateGanttConfig({ endDateRange: value });
const updateGanttConfig = useCallback((value: Partial<typeof initialGanttConfig>) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
...value,
}));
}, []);
const onScaleTypeChanged: ISelectBoxOptions['onValueChanged'] = useCallback(({ value }) => updateGanttConfig({ scaleType: value }), [updateGanttConfig]);
const onTaskTitlePositionChanged: ISelectBoxOptions['onValueChanged'] = useCallback(({ value }) => updateGanttConfig({ taskTitlePosition: value }), [updateGanttConfig]);
const onShowResourcesChanged: ICheckBoxOptions['onValueChanged'] = useCallback(({ value }) => updateGanttConfig({ showResources: value }), [updateGanttConfig]);
const onShowDependenciesChanged: ICheckBoxOptions['onValueChanged'] = useCallback(({ value }) => updateGanttConfig({ showDependencies: value }), [updateGanttConfig]);
const onShowCustomTaskTooltip: ICheckBoxOptions['onValueChanged'] = useCallback(({ value }) => updateGanttConfig({ showCustomTaskTooltip: value }), [updateGanttConfig]);
const onStartDateValueChanged: IDateBoxOptions['onValueChanged'] = useCallback(({ value }) => updateGanttConfig({ startDateRange: value }), [updateGanttConfig]);
const onEndDateValueChanged: IDateBoxOptions['onValueChanged'] = useCallback(({ value }) => updateGanttConfig({ endDateRange: value }), [updateGanttConfig]);

return (
<div id="form-demo">
Expand Down
47 changes: 34 additions & 13 deletions apps/demos/Demos/Gantt/Appearance/ReactJs/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, { useCallback, useState } from 'react';
import Gantt, {
Tasks,
Dependencies,
Expand Down Expand Up @@ -39,19 +39,40 @@ const initialGanttConfig = {
};
function App() {
const [ganttConfig, setGanttConfig] = useState(initialGanttConfig);
const updateGanttConfig = (value) =>
setGanttConfig({
...ganttConfig,
const updateGanttConfig = useCallback((value) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
...value,
});
const onScaleTypeChanged = ({ value }) => updateGanttConfig({ scaleType: value });
const onTaskTitlePositionChanged = ({ value }) => updateGanttConfig({ taskTitlePosition: value });
const onShowResourcesChanged = ({ value }) => updateGanttConfig({ showResources: value });
const onShowDependenciesChanged = ({ value }) => updateGanttConfig({ showDependencies: value });
const onShowCustomTaskTooltip = ({ value }) =>
updateGanttConfig({ showCustomTaskTooltip: value });
const onStartDateValueChanged = ({ value }) => updateGanttConfig({ startDateRange: value });
const onEndDateValueChanged = ({ value }) => updateGanttConfig({ endDateRange: value });
}));
}, []);
const onScaleTypeChanged = useCallback(
({ value }) => updateGanttConfig({ scaleType: value }),
[updateGanttConfig],
);
const onTaskTitlePositionChanged = useCallback(
({ value }) => updateGanttConfig({ taskTitlePosition: value }),
[updateGanttConfig],
);
const onShowResourcesChanged = useCallback(
({ value }) => updateGanttConfig({ showResources: value }),
[updateGanttConfig],
);
const onShowDependenciesChanged = useCallback(
({ value }) => updateGanttConfig({ showDependencies: value }),
[updateGanttConfig],
);
const onShowCustomTaskTooltip = useCallback(
({ value }) => updateGanttConfig({ showCustomTaskTooltip: value }),
[updateGanttConfig],
);
const onStartDateValueChanged = useCallback(
({ value }) => updateGanttConfig({ startDateRange: value }),
[updateGanttConfig],
);
const onEndDateValueChanged = useCallback(
({ value }) => updateGanttConfig({ endDateRange: value }),
[updateGanttConfig],
);
return (
<div id="form-demo">
<div className="options">
Expand Down
22 changes: 11 additions & 11 deletions apps/demos/Demos/Gantt/ContextMenu/React/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, { useCallback, useState } from 'react';
import Gantt, {
Tasks, Dependencies, Resources, ResourceAssignments, Column, Editing, ContextMenu,
} from 'devextreme-react/gantt';
Expand All @@ -16,19 +16,19 @@ function App() {
disableContextMenu: false,
contextMenuItems: getContextMenuItems(),
});
const onCustomizeContextMenu: ICheckBoxOptions['onValueChanged'] = ({ value }) => {
setGanttConfig({
...ganttConfig,
const onCustomizeContextMenu: ICheckBoxOptions['onValueChanged'] = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
contextMenuItems: value ? getContextMenuItems() : undefined,
});
};
}));
}, []);

const onPreventContextMenuShowing: ICheckBoxOptions['onValueChanged'] = ({ value }) => {
setGanttConfig({
...ganttConfig,
const onPreventContextMenuShowing: ICheckBoxOptions['onValueChanged'] = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
disableContextMenu: value,
});
};
}));
}, []);

return (
<div id="form-demo">
Expand Down
22 changes: 11 additions & 11 deletions apps/demos/Demos/Gantt/ContextMenu/ReactJs/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, { useCallback, useState } from 'react';
import Gantt, {
Tasks,
Dependencies,
Expand All @@ -19,18 +19,18 @@ function App() {
disableContextMenu: false,
contextMenuItems: getContextMenuItems(),
});
const onCustomizeContextMenu = ({ value }) => {
setGanttConfig({
...ganttConfig,
const onCustomizeContextMenu = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
contextMenuItems: value ? getContextMenuItems() : undefined,
});
};
const onPreventContextMenuShowing = ({ value }) => {
setGanttConfig({
...ganttConfig,
}));
}, []);
const onPreventContextMenuShowing = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
disableContextMenu: value,
});
};
}));
}, []);
return (
<div id="form-demo">
<div className="options">
Expand Down
22 changes: 11 additions & 11 deletions apps/demos/Demos/Gantt/Sorting/React/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, { useCallback, useState } from 'react';
import Gantt, {
Tasks, Dependencies, Resources, ResourceAssignments, Column, Editing, Sorting,
} from 'devextreme-react/gantt';
Expand All @@ -19,20 +19,20 @@ function App() {
showSortIndexes: false,
showSortIndexesDisabled: true,
});
const onSortingModeChanged: ISelectBoxOptions['onValueChanged'] = ({ value }) => {
setGanttConfig({
...ganttConfig,
const onSortingModeChanged: ISelectBoxOptions['onValueChanged'] = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
sortingMode: value,
showSortIndexesDisabled: value !== 'multiple',
});
};
}));
}, []);

const onShowSortIndexesChanged: ICheckBoxOptions['onValueChanged'] = ({ value }) => {
setGanttConfig({
...ganttConfig,
const onShowSortIndexesChanged: ICheckBoxOptions['onValueChanged'] = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
showSortIndexes: value,
});
};
}));
}, []);

return (
<div id="form-demo">
Expand Down
22 changes: 11 additions & 11 deletions apps/demos/Demos/Gantt/Sorting/ReactJs/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, { useCallback, useState } from 'react';
import Gantt, {
Tasks,
Dependencies,
Expand All @@ -22,19 +22,19 @@ function App() {
showSortIndexes: false,
showSortIndexesDisabled: true,
});
const onSortingModeChanged = ({ value }) => {
setGanttConfig({
...ganttConfig,
const onSortingModeChanged = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
sortingMode: value,
showSortIndexesDisabled: value !== 'multiple',
});
};
const onShowSortIndexesChanged = ({ value }) => {
setGanttConfig({
...ganttConfig,
}));
}, []);
const onShowSortIndexesChanged = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
showSortIndexes: value,
});
};
}));
}, []);
return (
<div id="form-demo">
<div className="options">
Expand Down
8 changes: 5 additions & 3 deletions apps/demos/Demos/Gantt/TaskTemplate/React/TaskTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, { useMemo } from 'react';

interface TaskTemplateProps {
taskData: {
Expand Down Expand Up @@ -26,16 +26,18 @@ function getTaskColor(taskId: number) {
}

export default function TaskTemplate({ taskData, taskSize, taskResources }: TaskTemplateProps) {
const taskWrapperStyle = useMemo(() => ({ width: `${taskSize.width}px` }), [taskSize.width]);
const progressStyle = useMemo(() => ({ width: `${taskData.progress}%` }), [taskData.progress]);
return (
<div className={`custom-task ${getTaskColor(taskData.id)}`} style={ { width: `${taskSize.width}px` } }>
<div className={`custom-task ${getTaskColor(taskData.id)}`} style={taskWrapperStyle}>
<div className="custom-task-img-wrapper">
<img className="custom-task-img" src={getImagePath(taskData.id)} />
</div>
<div className='custom-task-wrapper'>
<div className='custom-task-title'>{taskData.title}</div>
<div className='custom-task-row'>{taskResources[0].text}</div>
</div>
<div className='custom-task-progress' style={ { width: `${taskData.progress}%` } }></div>
<div className='custom-task-progress' style={progressStyle}></div>
</div>
);
}
8 changes: 5 additions & 3 deletions apps/demos/Demos/Gantt/TaskTemplate/ReactJs/TaskTemplate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, { useMemo } from 'react';

function getImagePath(taskId) {
const imgPath = '../../../../images/employees';
Expand All @@ -11,10 +11,12 @@ function getTaskColor(taskId) {
return `custom-task-color-${color}`;
}
export default function TaskTemplate({ taskData, taskSize, taskResources }) {
const taskWrapperStyle = useMemo(() => ({ width: `${taskSize.width}px` }), [taskSize.width]);
const progressStyle = useMemo(() => ({ width: `${taskData.progress}%` }), [taskData.progress]);
return (
<div
className={`custom-task ${getTaskColor(taskData.id)}`}
style={{ width: `${taskSize.width}px` }}
style={taskWrapperStyle}
>
<div className="custom-task-img-wrapper">
<img
Expand All @@ -28,7 +30,7 @@ export default function TaskTemplate({ taskData, taskSize, taskResources }) {
</div>
<div
className="custom-task-progress"
style={{ width: `${taskData.progress}%` }}
style={progressStyle}
></div>
</div>
);
Expand Down
32 changes: 16 additions & 16 deletions apps/demos/Demos/Gantt/Validation/React/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, { useCallback, useState } from 'react';
import Gantt, {
Tasks, Dependencies, Column, Validation, Editing,
} from 'devextreme-react/gantt';
Expand All @@ -13,26 +13,26 @@ function App() {
enablePredecessorGap: true,
});

const onEnablePredecessorGapChanged: ICheckBoxOptions['onValueChanged'] = ({ value }) => {
setGanttConfig({
...ganttConfig,
const onEnablePredecessorGapChanged: ICheckBoxOptions['onValueChanged'] = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
enablePredecessorGap: value,
});
};
}));
}, []);

const onAutoUpdateParentTasksChanged: ICheckBoxOptions['onValueChanged'] = ({ value }) => {
setGanttConfig({
...ganttConfig,
const onAutoUpdateParentTasksChanged: ICheckBoxOptions['onValueChanged'] = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
autoUpdateParentTasks: value,
});
};
}));
}, []);

const onValidateDependenciesChanged: ICheckBoxOptions['onValueChanged'] = ({ value }) => {
setGanttConfig({
...ganttConfig,
const onValidateDependenciesChanged: ICheckBoxOptions['onValueChanged'] = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
validateDependencies: value,
});
};
}));
}, []);

return (
<div id="form-demo">
Expand Down
32 changes: 16 additions & 16 deletions apps/demos/Demos/Gantt/Validation/ReactJs/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, { useCallback, useState } from 'react';
import Gantt, {
Tasks, Dependencies, Column, Validation, Editing,
} from 'devextreme-react/gantt';
Expand All @@ -11,24 +11,24 @@ function App() {
validateDependencies: true,
enablePredecessorGap: true,
});
const onEnablePredecessorGapChanged = ({ value }) => {
setGanttConfig({
...ganttConfig,
const onEnablePredecessorGapChanged = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
enablePredecessorGap: value,
});
};
const onAutoUpdateParentTasksChanged = ({ value }) => {
setGanttConfig({
...ganttConfig,
}));
}, []);
const onAutoUpdateParentTasksChanged = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
autoUpdateParentTasks: value,
});
};
const onValidateDependenciesChanged = ({ value }) => {
setGanttConfig({
...ganttConfig,
}));
}, []);
const onValidateDependenciesChanged = useCallback(({ value }) => {
setGanttConfig((prevConfig) => ({
...prevConfig,
validateDependencies: value,
});
};
}));
}, []);
return (
<div id="form-demo">
<div className="options">
Expand Down
Loading