Conversation
IlyaKhD
changed the title
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes are covered and no blocking issues remain.
Pull request overview
Updates SBOM generation with toolkit 0.14.0, package selection support, and isolated DevExtreme CLDR dependencies.
Changes:
- Refactors the SBOM Nx target and publishing workflow.
- Adds the
devextreme-extra-depsworkspace. - Updates documentation and dependency lockfiles.
File summaries
| File | Description |
|---|---|
packages/sbom/README.md |
Documents updated SBOM commands. |
packages/sbom/project.json |
Configures package-aware SBOM generation. |
packages/sbom/pnpm-lock.yaml |
Locks SBOM dependencies. |
packages/sbom/package.json |
Updates the SBOM toolkit dependency. |
packages/sbom/devextreme-extra-deps/pnpm-workspace.yaml |
Defines the isolated workspace. |
packages/sbom/devextreme-extra-deps/pnpm-lock.yaml |
Locks CLDR dependencies. |
packages/sbom/devextreme-extra-deps/package.json |
Declares additional CLDR dependencies. |
.github/workflows/packages_publishing.yml |
Uses the updated Nx SBOM target during publishing. |
Review details
Files not reviewed (2)
- packages/sbom/devextreme-extra-deps/pnpm-lock.yaml: Generated file
- packages/sbom/pnpm-lock.yaml: Generated file
- Files reviewed: 6/8 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The SBOM target has unresolved package fallback, path, and copy-error handling issues.
Get a fresh assessment by requesting another Copilot review.
Review details
Files not reviewed (2)
- packages/sbom/devextreme-extra-deps/pnpm-lock.yaml: Generated file
- packages/sbom/pnpm-lock.yaml: Generated file
Suppressed comments (1)
packages/sbom/project.json:23
- This makes the target succeed when
cpfails for any reason, not only whendevextreme.cdx.jsonis absent (for example, a permissions or disk-space failure). Keep the optional-file behavior while allowing copy errors to fail the SBOM step.
"test -f dist/devextreme.cdx.json && cp dist/devextreme.cdx.json dist/devextreme-dist.cdx.json || true"
- Files reviewed: 6/8 changed files
- Comments generated: 2
- Review effort level: Lite
IlyaKhD
force-pushed
the
khd/devextreme-extra-deps
branch
from
September 19, 2026 15:18
20fdc2b to
d0cd766
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.