Adds a testing notebook to run hera files from a notebook - #18
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 109 109
=========================================
Hits 109 109 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Matt-Carre
force-pushed
the
notebook_test
branch
3 times, most recently
from
July 27, 2026 10:08
75d0af4 to
ff4dcab
Compare
JamesDoingStuff
previously approved these changes
Jul 28, 2026
JamesDoingStuff
left a comment
JamesDoingStuff
left a comment
Collaborator
There was a problem hiding this comment.
Notebooks tested to be working 👍 I haven't reviewed any of the other files in this, so hold off on merging until #17 is in
Matt-Carre
force-pushed
the
notebook_test
branch
3 times, most recently
from
July 28, 2026 15:30
8551a2f to
c0b5b61
Compare
Collaborator
Author
|
Edited and fixed up now - pls review whenever ready :) |
Matt-Carre
force-pushed
the
notebook_test
branch
2 times, most recently
from
July 29, 2026 10:02
466f6e5 to
272f6a3
Compare
Matt-Carre
force-pushed
the
notebook_test
branch
from
July 29, 2026 10:27
272f6a3 to
6594a7b
Compare
TBThomas56
reviewed
Jul 29, 2026
TBThomas56
reviewed
Jul 29, 2026
TBThomas56
previously approved these changes
Jul 29, 2026
TBThomas56
left a comment
TBThomas56
left a comment
Collaborator
There was a problem hiding this comment.
suggest going through the comments and thought it is fine to approve and merge after those minor things are covered
TBThomas56
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review after #17
This shows that you can run hera from jupyter notebooks. This also includes a markdown box explaining how to run it - presumably these are standard steps in a dev container - haven't done it before so not sure.
Also not sure if this should be copied into the copier template - but have done so anyway for both versions, I can delete them if required.
With the {%raw%} tag, the notebook can be successfully copied over, hence why it's there. Best viewed after copying it.