Skip to content

ENG-2224 Set metadataBase and absolute canonical URLs - #1386

Merged
mdroidian merged 2 commits into
eng-2234-standardize-website-unit-test-configurationfrom
eng-2224-set-metadatabase-and-absolute-canonical-urls
Sep 7, 2026
Merged

ENG-2224 Set metadataBase and absolute canonical URLs#1386
mdroidian merged 2 commits into
eng-2234-standardize-website-unit-test-configurationfrom
eng-2224-set-metadatabase-and-absolute-canonical-urls

Conversation

@mdroidian

Copy link
Copy Markdown
Member

Configures the production metadataBase and adds explicit absolute canonical URLs across the public website route inventory, including dynamic blog and docs routes. Validation: pnpm install --frozen-lockfile and pnpm ci:validate passed. Separate delegated review returned no findings.

@linear-code

linear-code Bot commented Sep 2, 2026

Copy link
Copy Markdown

ENG-2224

@supabase

supabase Bot commented Sep 2, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
discourse-graph Ready Ready Preview Sep 7, 2026 4:22am UTC

Request Review

@graphite-app

graphite-app Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T04:24:03.400502Z 4edebb5 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mdroidian
mdroidian force-pushed the eng-2224-set-metadatabase-and-absolute-canonical-urls branch from d275d98 to 10984fd Compare September 7, 2026 02:51
@mdroidian
mdroidian changed the base branch from main to eng-2234-standardize-website-unit-test-configuration September 7, 2026 02:52
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

include: ["app/**/*.test.{ts,tsx}", "test/unit/**/*.test.{ts,tsx}"],

P2 Badge Include the existing search-index unit tests

When the root pnpm ci:validate command invokes this new website test task, the explicit include patterns run only app/seo.test.ts and exclude scripts/build-docs-search-index.test.mjs. Consequently, the existing four regression tests for canonical docs routes, search text extraction, platform filters, and build configuration remain absent from CI; include that test or invoke node --test from test:unit.

AGENTS.md reference: AGENTS.md:L97-L97

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mdroidian
mdroidian force-pushed the eng-2224-set-metadatabase-and-absolute-canonical-urls branch from 10984fd to 92d7cba Compare September 7, 2026 03:15
@mdroidian

Copy link
Copy Markdown
Member Author

The search-index test finding is addressed by a46c452 in #1406 and included in this rebased branch. The website test:unit command now runs all four existing Node search-index tests before Vitest. Frozen install, ci:validate, and GitHub checks passed. This is a general PR comment rather than a resolvable review thread.

@mdroidian
mdroidian merged commit 14429bc into eng-2234-standardize-website-unit-test-configuration Sep 7, 2026
8 checks passed
@mdroidian
mdroidian deleted the eng-2224-set-metadatabase-and-absolute-canonical-urls branch September 7, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant