ENG-1864 Define cross-app asset reference contract - #1392
Open
maparent wants to merge 2 commits into
Open
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
maparent
force-pushed
the
eng-1864-define-cross-app-asset-reference-contract
branch
from
September 4, 2026 11:17
9e12a8f to
82bf59e
Compare
maparent
force-pushed
the
eng-1864-define-cross-app-asset-reference-contract
branch
from
September 4, 2026 14:43
82bf59e to
d751472
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
731
to
733
| new Notice( | ||
| `Asset file ${attachment.path} is larger than 6Mb and will not be uploaded`, | ||
| ); |
Contributor
There was a problem hiding this comment.
The error message is inconsistent with the actual check. The code rejects assets when size >= 6MB (inclusive), but the message says "larger than 6Mb" (exclusive). A user with exactly a 6MB file will see this misleading message.
Fix:
new Notice(
`Asset file ${attachment.path} is 6MB or larger and will not be uploaded`,
);
Suggested change
| new Notice( | |
| `Asset file ${attachment.path} is larger than 6Mb and will not be uploaded`, | |
| ); | |
| new Notice( | |
| `Asset file ${attachment.path} is 6MB or larger and will not be uploaded`, | |
| ); | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
maparent
force-pushed
the
eng-1864-define-cross-app-asset-reference-contract
branch
from
September 4, 2026 18:23
d751472 to
36e0ff1
Compare
maparent
force-pushed
the
eng-1864-define-cross-app-asset-reference-contract
branch
from
September 6, 2026 22:32
36e0ff1 to
a243f7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer brief
The basic task is in the first commit, as given in the ticket.
The ticket mentions "oversized" assets; this requires defining size limits, which we put in another commit.
We could separate this into another ticket, but thought it's a clear enough prerequisite to fold.
The extra scope is defined in a note in the body of the ticket: asset size caps (both incoming and outgoing.)
Verification
The new reference contract is referenced in examples.
The asset size has tests.
Loom video
https://www.loom.com/share/be97dc663e7c43678eb0f8debc8af35c
Scope check
$scope-checkagainst the ENG ticket and final diff.Done When:The only extra scope is as noted at the end of the ticket .
Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.https://linear.app/discourse-graphs/issue/ENG-1864/define-cross-app-asset-reference-contract