ENG-2230 Split filepath and source_path across Obsidian publish and import - #1395
Open
maparent wants to merge 2 commits into
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
maparent
force-pushed
the
eng-2230-split-filepath-and-source_path-across-obsidian-publish-and
branch
from
September 5, 2026 14:42
6f81dd5 to
2add534
Compare
maparent
marked this pull request as ready for review
September 5, 2026 14:55
maparent
force-pushed
the
eng-2230-split-filepath-and-source_path-across-obsidian-publish-and
branch
from
September 6, 2026 14:37
2add534 to
1a826e3
Compare
Contributor
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
maparent
force-pushed
the
eng-2230-split-filepath-and-source_path-across-obsidian-publish-and
branch
2 times, most recently
from
September 6, 2026 15:01
1a826e3 to
4831cd1
Compare
maparent
force-pushed
the
eng-2230-split-filepath-and-source_path-across-obsidian-publish-and
branch
from
September 6, 2026 15:03
401a8e6 to
4831cd1
Compare
maparent
force-pushed
the
eng-2230-split-filepath-and-source_path-across-obsidian-publish-and
branch
from
September 6, 2026 22:32
4831cd1 to
7121858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer brief
This touches two things, in separate commits. (Could be split easily if desired.)
source_pathas a way to get a proper filename.While doing that, we discovered and fixed a related bug, see scope check point 3.
Corresponds to these OpenSpec tasks:
https://roamresearch.com/#/app/discourse-graphs/page/fmJkSx36O
Verification
Loom checks:
Importing roam data in Obsidian, collision detection:
https://www.loom.com/share/ae2f845d4b7c48e0a74adfdda12bb5bc
Import legacy asset
https://www.loom.com/share/44cdf4b1ec93428fb3c32cc591b0b057
Loom video
Code walkthrough forthcoming.
Scope check
Ran
$scope-checkagainst the ENG ticket and final diff.Scope beyond Done When: Three items.
FileReferenceper link spelling within a single note, where the old keying on the resolved path (attachment.path) collapsed them to one row (syncDgNodesToSupabase.ts:741-757,findEmbeddedAttachments at :693-708). Done When 6 covers spellings across two notes, which per-node keying already gave.updateMarkdownAssetLinksnow rewrites links whose text is a storage URL, consulting pathMapping before the http(s) early return in both the markdown-link and image branches (importNodes.ts:741-751, :774-800).metadataCache.getFirstLinkpathDestround trip on a just-written file is removed (importNodes.ts:673-678, :798-800), and setPathMapping is hoisted to one call with unsetPathMapping on failure so the reuse branch no longer drops the mapping (importNodes.ts:941-945, :1030-1035, :1125-1127).Required now:
Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.Two observations were postponed, written as "Decision taken" in the linear ticket.
https://linear.app/discourse-graphs/issue/ENG-2230/split-filepath-and-source-path-across-obsidian-publish-and-import