Skip to content

ENG-2218 Copy one asset from Supabase into Roam storage - #1397

Open
maparent wants to merge 1 commit into
eng-2216-Add-a-graph-level-asset-registry-accessor-for-Roamfrom
eng-2218-Copy-assets-from-supabase-into-Roam-storage
Open

ENG-2218 Copy one asset from Supabase into Roam storage#1397
maparent wants to merge 1 commit into
eng-2216-Add-a-graph-level-asset-registry-accessor-for-Roamfrom
eng-2218-Copy-assets-from-supabase-into-Roam-storage

Conversation

@maparent

@maparent maparent commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Reviewer brief

Verification

Loom video

Scope check

  • Ran $scope-check against the ENG ticket and final diff.
  • Scope beyond Done When: extractUploadedUrl accepts two upload-return shapes beyond the five the ticket enumerates — the bracket-less {{pdf|audio|video: url}} embed and label — marked in code as tolerance, not observed returns.
  • Required now: No ticket requires them. The argument is failure cost, not coverage: an unrecognised return throws after the bytes are already uploaded, orphaning a file in the user's storage and leaving the asset unresolved, and each retry orphans another. Every branch requires https?://, so the added tolerance cannot record a non-URL.
  • Anyone affected or consulted: No. This was proposed by the review agent.
  • Decision: Not documented — record the tolerance rationale in a Linear comment on ENG-2218 before merge; design.md Decision 4 documents the observed shapes only.

Local delegated full review

  • Ran a comprehensive review of the entire final diff in a subagent with a fresh context. Use $dg-delegated-full-review when no other full-review workflow is available.

https://linear.app/discourse-graphs/issue/ENG-2218/copy-one-asset-from-supabase-into-roam-storage

@linear-code

linear-code Bot commented Sep 5, 2026

Copy link
Copy Markdown

ENG-2218

@supabase

supabase Bot commented Sep 5, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel

vercel Bot commented Sep 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
discourse-graph Skipped Skipped Sep 6, 2026 10:59pm UTC

Request Review

@maparent
maparent force-pushed the eng-2218-Copy-assets-from-supabase-into-Roam-storage branch from f597a47 to 51a1453 Compare September 6, 2026 14:37
@maparent
maparent force-pushed the eng-2218-Copy-assets-from-supabase-into-Roam-storage branch from 51a1453 to 0c4df72 Compare September 6, 2026 15:04
@maparent
maparent force-pushed the eng-2218-Copy-assets-from-supabase-into-Roam-storage branch 2 times, most recently from 06de101 to 8653cb0 Compare September 6, 2026 16:40
@maparent
maparent force-pushed the eng-2218-Copy-assets-from-supabase-into-Roam-storage branch from 8653cb0 to 23e7946 Compare September 6, 2026 18:09
@maparent
maparent marked this pull request as ready for review September 6, 2026 20:09
@graphite-app

graphite-app Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@maparent
maparent force-pushed the eng-2218-Copy-assets-from-supabase-into-Roam-storage branch from 23e7946 to bbe9674 Compare September 6, 2026 22:32
@maparent
maparent force-pushed the eng-2218-Copy-assets-from-supabase-into-Roam-storage branch from bbe9674 to 0e1b241 Compare September 6, 2026 22:41
@maparent
maparent force-pushed the eng-2218-Copy-assets-from-supabase-into-Roam-storage branch from 0e1b241 to f88260d Compare September 6, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant