Add DG skill for wrapping HTML in Roam render code - #1405
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15a1d96ff9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d98425d65
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Reviewer brief
Add
dg-create-roam-render-html-codeto the DG skill collection. Serialize HTML as a JSON string literal so backslashes, template delimiters, and line endings survive exactly, and sandbox the generated iframe withallow-scriptswithout granting Roam's origin.Verification
node --test .agents/skills/dg-create-roam-render-html-code/scripts/renderer.test.mjspassed.pnpm install --frozen-lockfileandpnpm ci:validatepassed on the updated branch.Loom video
Not recorded. This draft adds a skill and its UI metadata without application changes.
Scope check
$scope-checkagainst the ENG ticket and final diff.Done When: No ENG ticket was supplied. Scope is the requested import and DG namespacing of the existing renderer skill.Local delegated full review