ENG-2143 Add Roam and Obsidian round-trip tests - #1412
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
|
||
| // Mirrors the storage boundary's local-reference resolution using fixed concept IDs. | ||
| // No adapter output is hand-written: the actual push result supplies the reference. | ||
| const storedSource = (input, references) => { |
There was a problem hiding this comment.
This helper simulates SQL reference resolution. Both apps' producers and importers run unchanged, so the assertions check the values passed between them.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce3ee8ac2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }; | ||
|
|
||
| type Row = Record<string, unknown>; | ||
| export const createHarness = () => { |
There was a problem hiding this comment.
Extracted from #1411 without behavior changes. All 20 importer test bodies remain identical to the stack base. The round-trip suite uses the same vault and database doubles.
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
1 participant
eng-2143.mp4
Reviewer brief
Depends on #1380, #1381, #1382, and #1411 through
eng-2143-source-adapters-base. Retarget tomainafter those land.Both apps' adapters run in the tests. Only platform I/O and SQL storage are simulated.
Verification
pnpm ci:validatepassed. 33 Obsidian tests and 269 Roam tests pass.Loom video
74-second feature demo above.
Scope check
$scope-checkagainst ENG-2143 and the final diff.Done When: None.Local delegated full review