Skip to content

chore: create dedicated service account collection - #48

Open
ASPactores wants to merge 9 commits into
mainfrom
chore/23-create-dedicated-service-account
Open

chore: create dedicated service account collection#48
ASPactores wants to merge 9 commits into
mainfrom
chore/23-create-dedicated-service-account

Conversation

@ASPactores

@ASPactores ASPactores commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📝 Overview

Add new collection for creating service accounts.

🚀 Type of Change

  • 🐛 Bug Fix: Fixed something that was broken.
  • New Feature: Added new functionality or pages.
  • 🗄️ CMS / Database: Updated collections, fields, or config in Payload CMS.
  • 🧹 Chore / Clean up: Text updates, typos, or code cleanup.

🧱 CMS & Database Changes

Skip this section if no CMS or database changes were made.

  • Migration Created: Ran payload migrate:create and saved the file.
  • Local Verification: Verified changes in the local admin panel.

📊 Data Structure

Describe the new fields/tables or drag-and-drop a screenshot here:


🧪 Testing & Validation

  • Test Case Approval: Verified that test cases were commented on the assigned GitHub issue and approved by the Project Lead before development started.
  • Unit Tests: Added or updated unit test scripts covering the new logic.
  • Admin Panel: Verified behavior in the CMS Admin UI.
  • API Check: Tested REST/GraphQL endpoints for correct data.

📸 Visual Evidence (Mandatory)

Important

Visual proof is required to demonstrate that the approved test cases from the issue were successfully met.
Please provide screenshots, screen recordings (GIFs/Videos), or sample API outputs proving that the feature satisfies all approved test cases and do not introduce regressions.


📋 Final Checklist

  • Sync: Rebased from main and resolved conflicts.
  • Pre-commit: Installed and ran pre-commit hooks successfully.
  • Security: Verified no secrets or local credentials are included.
  • Build: Project builds without errors.
  • Visuals: Attached mandatory visual evidence proving all test cases passed.
  • Migrations: Migration script included (if applicable).

🧠 Extra Notes / Questions

Add any additional context or questions for the reviewers here.

@ASPactores
ASPactores force-pushed the chore/23-create-dedicated-service-account branch from b3d426c to 5395e69 Compare August 4, 2026 13:17
@ASPactores
ASPactores requested a review from seangaaab August 4, 2026 13:18
@ASPactores ASPactores changed the title Chore/23 create dedicated service account chore: create dedicated service account collection Aug 4, 2026
@ASPactores
ASPactores marked this pull request as ready for review August 4, 2026 16:41
@ASPactores
ASPactores requested a review from a team August 4, 2026 16:41
@seangaaab
seangaaab force-pushed the chore/23-create-dedicated-service-account branch from ade62c0 to 7405d0a Compare August 10, 2026 16:29

@ASPactores ASPactores left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We just need to modify these collections and globals to reject anonymous reads:

Collections Needing access.read Changes (6 Collections)

Collection Slug File Location Current access.read Rule Proposed access.read Rule
categories src/collections/Categories.ts read: anyone read: checkResourceAccess
media src/collections/Media.ts read: anyone read: checkResourceAccess
durianpy-website-events src/collections/durianpy-website/Events.ts read: ({ req }) => req.user ? true : { _status: 'published' } read: checkEventsAccess('read')
durianpy-website-sigs src/collections/durianpy-website/SIGs.ts read: anyone read: checkSIGsAccess('read')
durianpy-website-sponsors src/collections/durianpy-website/Sponsors.ts read: anyone read: checkSponsorsAccess('read')
sample src/collections/durianpy-website/sample-website-collection.index.ts read: anyone read: checkSampleAccess('read')

Globals Needing access.read Changes (5 Globals)

Global Slug File Location Current access.read Rule Proposed access.read Rule
durianpy-website-homepage-config src/globals/durianpy-website/HomepageConfig.ts read: () => true read: checkHomepageConfigAccess('read')
durianpy-website-cta-section src/globals/durianpy-website/CTASection.ts read: anyone read: checkCTASectionAccess('read')
durianpy-website-statistics-config src/globals/durianpy-website/StatisticsConfig.ts read: () => true read: checkStatisticsConfigAccess('read')
durianpy-website-carousel src/globals/durianpy-website/Carousel.ts read: (access) => adminAccess(access) ? true : { _status: 'published' } read: checkCarouselAccess('read')
durianpy-website-code-of-conduct src/globals/durianpy-website/CodeOfConduct.ts read: anyone read: checkCodeOfConductAccess('read')

seangaaab
seangaaab previously approved these changes Aug 11, 2026

@seangaaab seangaaab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commits look great so far @ASPactores . We can merge this PR once you approve my commits

@ASPactores

Copy link
Copy Markdown
Contributor Author

LGTM!

@ASPactores
ASPactores requested a review from seangaaab August 16, 2026 02:14
seangaaab
seangaaab previously approved these changes Aug 16, 2026

@seangaaab seangaaab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants