fixed classic array creation with empty initialized - #82
Open
koenbeuk wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes code generation edge cases in the Roslyn source generator where empty initializers could produce syntactically invalid emitted C# (e.g., trailing commas in Expression.MemberInit(...) and Expression.NewArrayInit(...) calls), and adds a regression test to cover an empty classic array initializer.
Changes:
- Emit
Expression.MemberInit(newExpr)/Expression.NewArrayInit(type)without a trailing argument list when the initializer is empty. - Add a generator test for
new int[] { }to ensure the generated output compiles.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/ExpressiveSharp.Generator.Tests/ExpressiveGenerator/CollectionExpressionTests.cs | Adds a regression test for an empty classic array initializer. |
| src/ExpressiveSharp.Generator/Emitter/ExpressionTreeEmitter.cs | Adjusts emitter output to avoid generating invalid code for empty member/array initializers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+174
to
+175
| Assert.AreEqual(1, result.GeneratedTrees.Length); | ||
| Assert.IsFalse(result.Diagnostics.Any(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error)); |
Comment on lines
+1231
to
+1233
| AppendLine(bindingVars.Count == 0 | ||
| ? $"var {resultVar} = {Expr}.MemberInit({newVar});" | ||
| : $"var {resultVar} = {Expr}.MemberInit({newVar}, {string.Join(", ", bindingVars)});"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.