ensure to format with invariant culture - #83
Open
koenbeuk wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the source generator’s constant-literal emission to use invariant culture formatting, ensuring generated C# code is stable and culture-independent (important for consistent builds and snapshot outputs across different locales).
Changes:
- Formats integral literals (
long,ulong,uint,int, and casted smaller integrals) usingCultureInfo.InvariantCultureinstead of culture-sensitive interpolation/ToString(). - Adds an
IFormattablefallback to format any other formattable constant values with invariant culture. - Keeps existing round-trip formatting for
float/doubleand invariant formatting fordecimal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.