only report EXP0026 when the stub extensions are not in scope - #91
Open
koenbeuk wants to merge 1 commit into
Open
only report EXP0026 when the stub extensions are not in scope#91koenbeuk wants to merge 1 commit into
koenbeuk wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the MissingExpressiveImportAnalyzer (EXP0026) so it only reports when the ExpressiveSharp stub extension type isn’t actually in scope, avoiding false positives in cases where calls intentionally bind to System.Linq.Queryable (e.g., passing a pre-built Expression<Func<...>>).
Changes:
- Update the analyzer to check whether
ExpressiveQueryableLinqExtensionsis in scope before reporting EXP0026. - Add a regression test ensuring no EXP0026 is reported when
using ExpressiveSharp;is present and a pre-built expression tree is passed toWhere.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/ExpressiveSharp.Generator.Tests/CodeFixers/MissingExpressiveImportAnalyzerTests.cs | Adds a regression test for the “pre-built expression tree + using present” scenario to prevent EXP0026 false positives. |
| src/ExpressiveSharp.CodeFixers/MissingExpressiveImportAnalyzer.cs | Gates EXP0026 emission on whether the stub extension type is actually in scope at the call site. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.