PR Before-and-After backfill: catstack (4 PRs) - #399
Closed
EdbertChan wants to merge 12 commits into
Closed
Conversation
…fore and After` section to PR #383's description. Motivation: the PR text states the change but shows no example of old versus new behavior. Safety invariant: only the PR description changes; every other section stays byte-for-byte; no invented examples. Effectiveness measurement: the paired verify task reads the live PR back and checks the heading order and the new section. Exit code: 0
…tself that PR #383 now carries a visible Before and After section right after Summary with every other heading unchanged. Motivation: the backfill task's own report is not proof of the write; this reads the live PR back. Safety invariant: read-only; this task never writes to GitHub. Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed. Exit code: 0
…fore and After` section to PR #389's description. Motivation: the PR text states the change but shows no example of old versus new behavior. Safety invariant: only the PR description changes; every other section stays byte-for-byte; no invented examples. Effectiveness measurement: the paired verify task reads the live PR back and checks the heading order and the new section. Exit code: 0
…fore and After` section to PR #385's description. Motivation: the PR text states the change but shows no example of old versus new behavior. Safety invariant: only the PR description changes; every other section stays byte-for-byte; no invented examples. Effectiveness measurement: the paired verify task reads the live PR back and checks the heading order and the new section. Exit code: 0
…tself that PR #385 now carries a visible Before and After section right after Summary with every other heading unchanged. Motivation: the backfill task's own report is not proof of the write; this reads the live PR back. Safety invariant: read-only; this task never writes to GitHub. Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed. Exit code: 0
…tself that PR #389 now carries a visible Before and After section right after Summary with every other heading unchanged. Motivation: the backfill task's own report is not proof of the write; this reads the live PR back. Safety invariant: read-only; this task never writes to GitHub. Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed. Exit code: 0
…fore and After` section to PR #379's description. Motivation: the PR text states the change but shows no example of old versus new behavior. Safety invariant: only the PR description changes; every other section stays byte-for-byte; no invented examples. Effectiveness measurement: the paired verify task reads the live PR back and checks the heading order and the new section. Exit code: 0
…tself that PR #379 now carries a visible Before and After section right after Summary with every other heading unchanged. Motivation: the backfill task's own report is not proof of the write; this reads the live PR back. Safety invariant: read-only; this task never writes to GitHub. Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed. Exit code: 0
…aa696d3 — Goal: prove from GitHub itself that PR #379 now carries a visible Before and After section right after Summary with every other heading unchanged. Motivation: the backfill task's own report is not proof of the write; this reads the live PR back. Safety invariant: read-only; this task never writes to GitHub. Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed.
…d1bd67b — Goal: prove from GitHub itself that PR #383 now carries a visible Before and After section right after Summary with every other heading unchanged. Motivation: the backfill task's own report is not proof of the write; this reads the live PR back. Safety invariant: read-only; this task never writes to GitHub. Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed.
…1e37592 — Goal: prove from GitHub itself that PR #385 now carries a visible Before and After section right after Summary with every other heading unchanged. Motivation: the backfill task's own report is not proof of the write; this reads the live PR back. Safety invariant: read-only; this task never writes to GitHub. Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed.
…ab3be07 — Goal: prove from GitHub itself that PR #389 now carries a visible Before and After section right after Summary with every other heading unchanged. Motivation: the backfill task's own report is not proof of the write; this reads the live PR back. Safety invariant: read-only; this task never writes to GitHub. Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_cec43170-2a70-46f0-9d0c-c4ea19999c47) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backfilled real-run before/after examples in catstack PRs #379, #383, #385, and #389 so reviewers can see each proposed behavior change.
Live GitHub reads confirm all four sections immediately follow Summary. The examples use focused probes; their underlying behavior runs were not repeated during this review.
This branch has no file changes against main; it records completed PR-description updates and requires no code merge.
Before and After
Previously, the four descriptions lacked paired examples. Each now contains a
## Before and Aftersection with recorded base/head output:intervention-must-automate: no (count=0).yes (count=3).AttributeError, exit 1.loaded: Promise(text='x'), exit 0.Review Claim
Each targeted PR now exposes its recorded behavior comparison immediately after Summary.
Review Lane
docs
Review Unit
docs
Safety Invariant
Only the targeted PR descriptions may change. Preserve all content outside the inserted section byte-for-byte; leave code, commits, branches, labels, reviews, and merge state untouched. Never invent examples.
Slice Rationale
The four edits share one documentation purpose and paired read-only verification. The supplied workflow reports eight completed tasks and four passed verification tasks.
Assumptions: the supplied workflow defines the scope and safety invariant. This body documents external description edits; the empty repository diff is not a publishable code slice.
Non-goals
Changing the underlying implementations, expanding test coverage, or editing other PR sections or metadata.
Test Plan
Test Plan
gh api repos/EdbertChan/catstack/pulls/379 --jq .body, repeated for383,385, and389.git diff --quiet main...HEAD— exit 0; no repository file changes.python3 engine/skills/make-pr/scripts/preflight.py --base main— output:no changed files vs main.node engine/skills/draft-pr/scripts/validate-pr-body.mjs --body-file /tmp/catstack-backfill-pr-body.md --config drafter.config.json --changed-files-file /tmp/catstack-backfill-files.txt --diff-file /tmp/catstack-backfill.diff—PR body validation passed.Fixture/probe evidence: the live descriptions contain recorded base/head runs. Those behavior probes were not rerun here.
Verification limit: heading checks establish section placement and heading preservation, not byte-for-byte preservation of other content. Original body snapshots were not available for that comparison.
Revert Plan
Revert Plan
gh pr edit <number> --repo EdbertChan/catstack --body-file <reviewed-restored-body.md>for each of the four PRs.Note
Low Risk
No repository code or config changes; only external PR description edits are in scope, with an explicit invariant not to touch implementations or other metadata.
Overview
This branch carries no git diff against
main—the change is entirely on GitHub: add a## Before and Aftersection (right after Summary) to PRs #379, #383, #385, and #389, using workflow-recorded behavior pairs (provenance checker, stop hook, audit/automation trigger, dataclass probe).This PR’s description documents that backfill and verification (heading order via
gh api); it does not implement the underlying behavior in those four PRs. Publication is blocked becausepreflight/ repo policy requires changed files vsmain, which this slice intentionally lacks.Reviewed by Cursor Bugbot for commit 97e90af. Bugbot is set up for automated code reviews on this repo. Configure here.