Skip to content

PR Before-and-After backfill: catstack (4 PRs) - #399

Closed
EdbertChan wants to merge 12 commits into
mainfrom
plan/pr-before-and-after-backfill-catstack-4-prs
Closed

PR Before-and-After backfill: catstack (4 PRs)#399
EdbertChan wants to merge 12 commits into
mainfrom
plan/pr-before-and-after-backfill-catstack-4-prs

Conversation

@EdbertChan

@EdbertChan EdbertChan commented Sep 11, 2026

Copy link
Copy Markdown
Owner

Summary

Backfilled real-run before/after examples in catstack PRs #379, #383, #385, and #389 so reviewers can see each proposed behavior change.

Live GitHub reads confirm all four sections immediately follow Summary. The examples use focused probes; their underlying behavior runs were not repeated during this review.

This branch has no file changes against main; it records completed PR-description updates and requires no code merge.

Before and After

Previously, the four descriptions lacked paired examples. Each now contains a ## Before and After section with recorded base/head output:

PR Before After
#379 Provenance checker accepts a bare repository PR reference. Checker flags the same rule text.
#383 Hook nudges about a qualified marker and misses a later causal claim. Hook flags the later claim and drops the marker nudge.
#385 Session audit reports intervention-must-automate: no (count=0). Same session reports yes (count=3).
#389 Dataclass probe raises AttributeError, exit 1. Probe prints loaded: Promise(text='x'), exit 0.

Review Claim

Each targeted PR now exposes its recorded behavior comparison immediately after Summary.

Review Lane

docs

Review Unit

docs

Safety Invariant

Only the targeted PR descriptions may change. Preserve all content outside the inserted section byte-for-byte; leave code, commits, branches, labels, reviews, and merge state untouched. Never invent examples.

Slice Rationale

The four edits share one documentation purpose and paired read-only verification. The supplied workflow reports eight completed tasks and four passed verification tasks.

Assumptions: the supplied workflow defines the scope and safety invariant. This body documents external description edits; the empty repository diff is not a publishable code slice.

Non-goals

Changing the underlying implementations, expanding test coverage, or editing other PR sections or metadata.

Test Plan

Test Plan
  • Live reads: gh api repos/EdbertChan/catstack/pulls/379 --jq .body, repeated for 383, 385, and 389.
  • Read-only Python assertions over those responses: PASS for all four PRs; exact heading order matches Summary → Before and After → the eight remaining canonical headings, with nonempty before/after evidence.
  • git diff --quiet main...HEAD — exit 0; no repository file changes.
  • python3 engine/skills/make-pr/scripts/preflight.py --base main — output: no changed files vs main.
  • node engine/skills/draft-pr/scripts/validate-pr-body.mjs --body-file /tmp/catstack-backfill-pr-body.md --config drafter.config.json --changed-files-file /tmp/catstack-backfill-files.txt --diff-file /tmp/catstack-backfill.diffPR body validation passed.

Fixture/probe evidence: the live descriptions contain recorded base/head runs. Those behavior probes were not rerun here.

Verification limit: heading checks establish section placement and heading preservation, not byte-for-byte preservation of other content. Original body snapshots were not available for that comparison.

Revert Plan

Revert Plan
  • Safe to revert? Yes, after checking for subsequent description edits.
  • Revert action: remove only the inserted Before and After section from each targeted PR, preserving all other current content.
  • Revert command: gh pr edit <number> --repo EdbertChan/catstack --body-file <reviewed-restored-body.md> for each of the four PRs.
  • Post-revert steps: read each live body back and compare it with the reviewed restoration. Reverting a git commit cannot undo these GitHub description edits.
  • Data migration? No.

Note

Low Risk
No repository code or config changes; only external PR description edits are in scope, with an explicit invariant not to touch implementations or other metadata.

Overview
This branch carries no git diff against main—the change is entirely on GitHub: add a ## Before and After section (right after Summary) to PRs #379, #383, #385, and #389, using workflow-recorded behavior pairs (provenance checker, stop hook, audit/automation trigger, dataclass probe).

This PR’s description documents that backfill and verification (heading order via gh api); it does not implement the underlying behavior in those four PRs. Publication is blocked because preflight / repo policy requires changed files vs main, which this slice intentionally lacks.

Reviewed by Cursor Bugbot for commit 97e90af. Bugbot is set up for automated code reviews on this repo. Configure here.

…fore and After` section to PR #383's description.

Motivation: the PR text states the change but shows no example of old versus new behavior.
Safety invariant: only the PR description changes; every other section stays byte-for-byte; no invented examples.
Effectiveness measurement: the paired verify task reads the live PR back and checks the heading order and the new section.

Exit code: 0
…tself that PR #383 now carries a visible Before and After section right after Summary with every other heading unchanged.

Motivation: the backfill task's own report is not proof of the write; this reads the live PR back.
Safety invariant: read-only; this task never writes to GitHub.
Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed.

Exit code: 0
…fore and After` section to PR #389's description.

Motivation: the PR text states the change but shows no example of old versus new behavior.
Safety invariant: only the PR description changes; every other section stays byte-for-byte; no invented examples.
Effectiveness measurement: the paired verify task reads the live PR back and checks the heading order and the new section.

Exit code: 0
…fore and After` section to PR #385's description.

Motivation: the PR text states the change but shows no example of old versus new behavior.
Safety invariant: only the PR description changes; every other section stays byte-for-byte; no invented examples.
Effectiveness measurement: the paired verify task reads the live PR back and checks the heading order and the new section.

Exit code: 0
…tself that PR #385 now carries a visible Before and After section right after Summary with every other heading unchanged.

Motivation: the backfill task's own report is not proof of the write; this reads the live PR back.
Safety invariant: read-only; this task never writes to GitHub.
Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed.

Exit code: 0
…tself that PR #389 now carries a visible Before and After section right after Summary with every other heading unchanged.

Motivation: the backfill task's own report is not proof of the write; this reads the live PR back.
Safety invariant: read-only; this task never writes to GitHub.
Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed.

Exit code: 0
…fore and After` section to PR #379's description.

Motivation: the PR text states the change but shows no example of old versus new behavior.
Safety invariant: only the PR description changes; every other section stays byte-for-byte; no invented examples.
Effectiveness measurement: the paired verify task reads the live PR back and checks the heading order and the new section.

Exit code: 0
…tself that PR #379 now carries a visible Before and After section right after Summary with every other heading unchanged.

Motivation: the backfill task's own report is not proof of the write; this reads the live PR back.
Safety invariant: read-only; this task never writes to GitHub.
Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed.

Exit code: 0
…aa696d3 — Goal: prove from GitHub itself that PR #379 now carries a visible Before and After section right after Summary with every other heading unchanged.

Motivation: the backfill task's own report is not proof of the write; this reads the live PR back.
Safety invariant: read-only; this task never writes to GitHub.
Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed.
…d1bd67b — Goal: prove from GitHub itself that PR #383 now carries a visible Before and After section right after Summary with every other heading unchanged.

Motivation: the backfill task's own report is not proof of the write; this reads the live PR back.
Safety invariant: read-only; this task never writes to GitHub.
Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed.
…1e37592 — Goal: prove from GitHub itself that PR #385 now carries a visible Before and After section right after Summary with every other heading unchanged.

Motivation: the backfill task's own report is not proof of the write; this reads the live PR back.
Safety invariant: read-only; this task never writes to GitHub.
Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed.
…ab3be07 — Goal: prove from GitHub itself that PR #389 now carries a visible Before and After section right after Summary with every other heading unchanged.

Motivation: the backfill task's own report is not proof of the write; this reads the live PR back.
Safety invariant: read-only; this task never writes to GitHub.
Effectiveness measurement: exits non-zero if the section is missing or misplaced, or any original heading changed.
@cursor

cursor Bot commented Sep 11, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_cec43170-2a70-46f0-9d0c-c4ea19999c47)

@EdbertChan EdbertChan closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants