Skip to content

diu word lists: five kinds of wording to avoid in replies - #446

Merged
mergify[bot] merged 1 commit into
mainfrom
plan/plain-words-phrase-lists
Sep 12, 2026
Merged

diu word lists: five kinds of wording to avoid in replies#446
mergify[bot] merged 1 commit into
mainfrom
plan/plain-words-phrase-lists

Conversation

@EdbertChan

@EdbertChan EdbertChan commented Sep 11, 2026

Copy link
Copy Markdown
Owner

Summary

Five new word lists say which kinds of wording confuse the user in replies, with real examples of each.

They come from twenty times the user asked "what do you mean" in recent chats.

They live with diu, the reply checker. Nothing reads them yet; the PR above this one has diu use them.

Review Claim

Five phrase lists, engine/hooks/diu-stop/phrases/plain-words-*.json, one per kind of confusing wording, each loadable by phrases.load(name, directory=...), plus a test that they load and carry no PR numbers or dates.

Review Lane

behavior

Review Unit

engine-runtime

Safety Invariant

Data files and one test only. Nothing reads these lists yet, so no hook and no reply changes.

Slice Rationale

The lists are what diu will read, so they land first and on their own, in diu's own folder.

The branch is now one commit on main. It previously sat on the phrase-list-format PR, which has merged, and carried that PR's commits too; those are gone, so the diff is these six files.

The five kinds are: words the assistant made up, raw code or setting names, internal tool names, tech jargon and abbreviations, and status words. Each list reads the user's message as well as the reply, so a word the user used first does not count.

Non-goals

  • diu does not read the lists in this PR.
  • No change to the phrase-list loader or the judge.
  • No regex: the model judges meaning against the examples.

Test Plan

Test Plan

Run on the rebuilt branch, one commit on main:

  • python3 -m unittest discover -s engine/hooks/diu-stop/tests: Ran 97 tests ... OK
  • uvx ruff check . --select E9,F: All checks passed!
  • The rebuild keeps exactly the old changes: git patch-id --stable matches the old range's patch id
  • Live check with the real judge, Claude runner only, loading plain-words-made-up-labels from diu's folder: "No hook decides differently. The hooks only gain replay functions." returned match: True, closest "The hooks only gain replay functions." (7.6s); "Yes. The hook's logic stays the same; this is a simple refactor." returned match: False (9.4s).

Revert Plan

Revert Plan
  • Safe to revert? Yes. Nothing reads the lists.
  • Revert command: git revert <merge-sha>
  • Post-revert steps: None.
  • Data migration? No

🤖 Generated with Claude Code

https://claude.ai/code/session_01Gnua5cuAAF1ey1b7zRqJCC

@cursor

cursor Bot commented Sep 11, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_465c380a-e14e-4dd4-89e5-3cb519bae037)

@cursor

cursor Bot commented Sep 11, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_b460767c-a672-4ac1-82d6-39e3e6ccc911)

@EdbertChan EdbertChan changed the title Phrase lists: five kinds of wording to avoid in replies diu word lists: five kinds of wording to avoid in replies Sep 11, 2026
@EdbertChan
EdbertChan changed the base branch from plan/phrase-judge-1-checkers-declare-meaning-as-phrase-dictionaries to main September 12, 2026 01:05
@mergify

mergify Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

Five phrase lists under engine/hooks/diu-stop/phrases/ name the kinds of wording that left the user asking what a reply meant: words the assistant made up, raw code or setting names, internal tool names, tech jargon and abbreviations, and status words. Data and one test only; nothing reads them yet.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Gnua5cuAAF1ey1b7zRqJCC
Change-Id: I4860c82b5b8a8a6b84a9397e289c7023fd5d7730
@EdbertChan
EdbertChan force-pushed the plan/plain-words-phrase-lists branch from 0c3ab81 to eea6f19 Compare September 12, 2026 01:09
@cursor

cursor Bot commented Sep 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_c606b307-3470-441f-8724-6fb26589ab43)

@EdbertChan

Copy link
Copy Markdown
Owner Author

@Mergifyio queue

@mergify

mergify Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 5 minutes 23 seconds in the queue, including 4 minutes 4 seconds running CI.

Required conditions to merge
  • check-success = lint
  • check-success = test

@mergify mergify Bot added the queued label Sep 12, 2026
@mergify
mergify Bot merged commit a3d24a8 into main Sep 12, 2026
4 checks passed
@mergify mergify Bot removed the queued label Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant