merge queue: checking #472 on main (e9a9750) - #476
Closed
mergify[bot] wants to merge 2 commits into
Closed
Conversation
repo_root() decided which repository it was looking at from the session's cwd
alone, so a session working in another repo that edits catstack through an
absolute path or a worktree got no reminder at all.
That is what happened today: engine/hooks/unverified-tag-ledger and install.sh
were written and committed from a session whose cwd was a different repo, the
Stop hook stayed silent every turn, and both PRs went up with no draft-pr
schema until the user noticed.
cwd stays the first check and is unchanged. When it does not resolve to
catstack, repo_root() now reads the file paths this session's tool calls named
and runs each through the same _accept_root() gate, so the fallback can only
ever widen detection and can never return a directory outside catstack.
Replayed against the real transcript of that session, cwd left as its own:
BEFORE repo_root -> None decide -> None
AFTER repo_root -> .../catstack/.worktrees/autopr-foreign
decide -> "catstack changes detected on branch ..."
30 tests pass, including a positive case (foreign cwd + a touched catstack
path fires), a negative case (touched paths outside catstack stay silent), an
unchanged-behaviour case for a cwd inside catstack, and an unreadable
transcript reporting on stderr rather than failing quietly.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018u8S5ct3kFhosinSbybc7W
Change-Id: I77563afdcde6b7dde30dc046ff69ab637648d84f
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Pull request #472 has been merged manually at de78102. ✨
#472 is queued for merge on branch main (e9a9750).
This pull request has been created by Mergify to check the mergeability of #472.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
admin-bypassfor merge:check-success = testcheck-success = lintRequired conditions to stay in the queue:
-draftbase=mainlabel=admin-bypass