feat(ci): fail when a phrase checker has nothing calling it

[EdbertChan]

Summary

A rule can be written in this repo and have nothing calling it. It then reads as
covered in review and never fires.

The build now fails when that happens. A word-list rule has to be reachable from
code, or say in writing why it ships switched off.

Nothing is switched off by this change and no rule text changes. It only adds a
check.

Review Claim

The build fails unless every phrase checker is named in quotes by a non-test
file, discovered at runtime by a file in its own hook that lists the phrases
directory, or declares an unwired_reason.

Review Lane

behavior

Review Unit

engine-runtime

Safety Invariant

The check only reads files and returns an exit code. It runs in CI, imports
nothing from the hooks it inspects, and changes no runtime behaviour, so the
worst failure it can cause is a red build.

Slice Rationale

The check ships alone because everything it inspects already exists and already
passes. It needed no companion change, which is also why it could be verified
against the real tree rather than a fixture.

Non-goals

• Adds no wordlist and changes no rule text. Judgement stays with the model.
• Does not cover hooks or skills; test_install.py and the three-harness gate
  already do those.
• Does not check that a caller is ever actually reached at runtime, only that
  one exists.

Test Plan

Test Plan

• python3 tests/test_rules_are_wired.py
• python3 scripts/check_rules_are_wired.py
• python3 tests/test_check_docstrings_match_regexes.py

Two wrong answers were found while building this, both now pinned by tests.

First, matching the name anywhere in a file passed example off three files that
only used the word in prose:

example -> ['engine/hooks/scratchpad-collision/detect.py',
            'engine/hooks/llm-judge/phrases.py',
            'engine/hooks/no-comments/detect.py']

Requiring the quoted form then failed all five plain-words-* checkers, which
are genuinely wired — diu-stop/plain_words.py loads them by listing the
directory, so it names none of them. A check that only understood literals would
have failed the repo's own working code.

Final behaviour on the real tree:

dynamic plain-words-code-names: loaded by engine/hooks/diu-stop/plain_words.py
dynamic plain-words-internal-names: loaded by engine/hooks/diu-stop/plain_words.py
dynamic plain-words-made-up-labels: loaded by engine/hooks/diu-stop/plain_words.py
dynamic plain-words-status-words: loaded by engine/hooks/diu-stop/plain_words.py
dynamic plain-words-tech-jargon: loaded by engine/hooks/diu-stop/plain_words.py
opt-out example: the worked example for llm-judge's README ...
check_rules_are_wired: OK (7 checker(s) checked)

The promised catch and allow exemplars, run:

CATCH (must all be True):
  no-caller            -> True
  prose-mention-only   -> True
  empty-unwired-reason -> True
  no-checker-name      -> True
ALLOW (must all be False):
  quoted-caller         -> False
  stated-unwired-reason -> False
  runtime-discovery     -> False

Suites:

Ran 18 tests in 4.035s    OK    (the check)
Ran 5 tests in 1.561s     OK    (the meta-gate that audits every gate)

Fixture vs live: the check runs against this repo's own tree above, not a
fixture. It has no runtime side effects to exercise.

Revert Plan

Revert Plan

• Safe to revert? Yes
• Revert command: git revert <sha>
• Post-revert steps: None. The build stops checking; nothing else changes.
• Data migration? No

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_61dded38-074e-43cf-8f9f-5177dac8d57d)

[EdbertChan]

@Mergifyio queue

[mergify]

Merge Queue Status

• 🟠 Waiting for queue conditions
• ⏳ Enter queue
• ⏳ Run checks
• ⏳ Merge

Waiting for

• -closed [📌 queue requirement]

All conditions

• -closed [📌 queue requirement]
• -conflict [📌 queue requirement]
• -draft [📌 queue requirement]
• any of [📌 queue -> configuration change requirements]:
  • -mergify-configuration-changed
  • check-success = @mergify/Configuration changed
  • check-success = @mergify/Configuration has been deleted
• any of [🔀 queue conditions]:
  • all of [📌 queue conditions of queue rule admin-bypass]:
    • -draft
    • base=main
    • label=admin-bypass