Skip to content

Add SimpleSwap swap provider - #6144

Closed
j0ntz wants to merge 1 commit into
developfrom
jon/1217205278669378
Closed

Add SimpleSwap swap provider#6144
j0ntz wants to merge 1 commit into
developfrom
jon/1217205278669378

Conversation

@j0ntz

@j0ntz j0ntz commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

EdgeApp/edge-exchange-plugins#481 — the SimpleSwap plugin itself. This PR only registers it, so it is inert until that lands and publishes.

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Description

Asana: https://app.asana.com/0/1215088146871429/1217205278669378

Registers SimpleSwap, the swap provider added in
EdgeApp/edge-exchange-plugins#481,
so the plugin the partner wrote actually loads in the app.

  • src/envConfig.tsSIMPLESWAP_INIT with an apiKey, matching the other
    centralized providers. An empty key makes the plugin factory throw, so builds
    without the key skip SimpleSwap entirely.
  • src/util/corePlugins.ts — the swapPlugins entry.
  • src/components/modals/SwapVerifyTermsModal.tsx — the terms, privacy and
    AML/KYC links shown before the first SimpleSwap quote.
  • src/actions/CategoriesActions.ts and src/constants/MerchantContacts.ts
    the provider icon and merchant contact.

The icon path exchangeIcons/simpleswap/icon.png is not on the content server
yet; the asset upload is an ops step outside this repo.

Testing

Driven on the iOS simulator against the real SimpleSwap API, with every other
swap provider disabled locally so the engine had to route through SimpleSwap:
a live XLM to XMR swap from My Stellar executed to the success scene, and the
Stellar send carried SimpleSwap's numeric deposit memo. Screenshots below.


Note

Low Risk
Registration-only GUI changes with no auth or payment logic; provider stays inactive without an API key and depends on the separate exchange-plugins release.

Overview
Adds SimpleSwap as a centralized swap provider in the app shell, aligned with other partners like SideShift and Swapuz. The live swap logic ships in edge-exchange-plugins; this change only wires the provider into Edge.

Configuration: SIMPLESWAP_INIT in env config accepts an optional apiKey (same pattern as other centralized providers). An empty key means the plugin factory does not load SimpleSwap.

User-facing: First-quote terms, privacy, and AML/KYC links in SwapVerifyTermsModal, plus exchange icon mapping and a MerchantContacts entry for history/details branding.

CHANGELOG notes SimpleSwap as a new swap provider.

Reviewed by Cursor Bugbot for commit 2138216. Bugbot is set up for automated code reviews on this repo. Configure here.

@j0ntz

j0ntz commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence

simpleswap terms modal

simpleswap terms modal

simpleswap quote

simpleswap quote

swap success

swap success

xlm tx with memo

xlm tx with memo

stellar broadcast

stellar broadcast

Captured by the agent's in-app test run (build-and-test).

Registers the SimpleSwap swap plugin from edge-exchange-plugins: the
SIMPLESWAP_INIT env config, the core plugin entry, the provider icon and
merchant contact, and the terms/privacy/AML links the swap terms modal
shows before the first quote.
@j0ntz
j0ntz marked this pull request as ready for review August 7, 2026 00:00
@j0ntz
j0ntz force-pushed the jon/1217205278669378 branch from 7ec4c0f to 2138216 Compare August 7, 2026 00:00
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@j0ntz

j0ntz commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate: SimpleSwap already submitted the same GUI wiring in #6136, which additionally supplies the logo assets for the content server. I opened this before spotting theirs. The verification stands and the test-evidence screenshots are being moved to #6136.

@j0ntz j0ntz closed this Aug 7, 2026
@j0ntz
j0ntz deleted the jon/1217205278669378 branch August 7, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant