Support Iceberg decimals with 38-digit precision - #67
Merged
Conversation
osipovartem
force-pushed
the
decimal-38-fastnum-df55
branch
from
September 2, 2026 12:19
bbe112f to
446feb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust_decimalvalue used by Iceberg bounds withfastnum::D128decimal(38, s)value range in metadata and pruning statisticsDecimal128The approach adapts the decimal representation used by Apache iceberg-rust for full 38-digit precision to this fork's
Valuemodel.Why
Snowflake can write 38-digit decimal lower/upper bounds into Iceberg metadata. Decoding those values through
rust_decimalpanicked because its mantissa is limited to 96 bits, so Rustice could not read otherwise valid Snowflake Iceberg tables.Verification
cargo +1.94.0 test -p iceberg-rust-spec --lib(151 passed, 1015 explicitly ignored)cargo +1.94.0 test -p datafusion_iceberg --lib(50 passed)cargo +stable clippy --all-targets --all-features -- -D warningscargo +stable fmt --all -- --checkDecimal128