Skip to content

test(cli): isolate skill removal cache fixtures - #444

Merged
christso merged 1 commit into
mainfrom
fix/remove-skill-timeout
Jul 30, 2026
Merged

test(cli): isolate skill removal cache fixtures#444
christso merged 1 commit into
mainfrom
fix/remove-skill-timeout

Conversation

@christso

Copy link
Copy Markdown
Contributor

Summary

The skill-removal suite now stays inside its explicit AllAgents test home instead of missing its cache fixture and attempting a real GitHub clone in CI. The affected tests also prove that the intended cached plugin paths were discovered, so a failed fetch cannot produce a false green.

Validation

Red reproduction on origin/main:

ALLAGENTS_TEST_HOME=/tmp/allagents-skill-removal-red-90740423134 bun test tests/unit/cli/skill-removal.test.ts --timeout 5000

The target case timed out at 5004 ms and Bun killed one dangling clone process.

Green verification:

bun test tests/unit/cli/skill-removal.test.ts tests/unit/core/skills.test.ts tests/unit/core/plugin.test.ts tests/unit/constants.test.ts --timeout 5000
bun test
bun run lint
bun run typecheck
bun run build
  • Focused coverage: 32 passed, 1 Windows-only skip.
  • Stress coverage: 50 isolated iterations, 900 passes, and no writes to the ambient test home.
  • Full suite: 1,347 passed, 5 skipped, 0 failed.
  • No manual CLI E2E was needed because production code and runtime behavior are unchanged.

Related: failing Actions job

Post-Deploy Monitoring & Validation

No additional operational monitoring required because this is a test-only isolation fix with no production/runtime impact. The PR Test job is the validation signal; a timeout or dangling-process report in removeInstalledSkill is the rollback trigger. Validation window: this PR's CI run. Owner: repository maintainer.


Compound Engineering

@christso
christso merged commit 50ba5f6 into main Jul 30, 2026
5 checks passed
@christso
christso deleted the fix/remove-skill-timeout branch July 30, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant