feat: Create fake path for codechecker - #308
Conversation
nettle
left a comment
There was a problem hiding this comment.
I think we are just missing evidences here (use-case? tests?).
That's why this change does not look convincing to me so far.
Is it a part bigger change?
|
I'm not sure I understand your concerns. The main goal of this patch is to move away from using On the note of tests, since I'm only changing the environment codechecker runs in, any test running a codechecker analysis (e.g.: |
OK, it's getting clearer... Thanks for explanation! |
|
Maybe it's just a naming problem. Since we are creating our own PATH within the sandbox, it might be better to call it something else. The idea is that CodeChecker will need to find dirname (originally I thought multiple utilities: uname, openssl) in PATH. (I found no way to directly provide the dirname utility for CodeChecker.) So I add the folder containing all tools (in this case, just dirname) to the toolchain provider, add that folder to the PATH, and let the run_files attribute handle the dependencies. |
Why:
We want the Bazel rule to be as hermetic as possible.
What:
Addresses:
none
Notes:
Supporting standalone builds of CodeChecker, however, will still require Python in PATH.