Skip to content

test: Get rid of wget in foss tests - #328

Merged
nettle merged 1 commit into
Ericsson:mainfrom
nettle:remove-wget
Sep 3, 2026
Merged

test: Get rid of wget in foss tests#328
nettle merged 1 commit into
Ericsson:mainfrom
nettle:remove-wget

Conversation

@nettle

@nettle nettle commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Why:
We still have wget as environment dependency
managed by micromamba, but package download
can be implemented in python instead.

What:

  • Download package using python
  • Remove wget from micromamba

@nettle nettle added enhancement New feature or request test ☑️ Adding or refactoring tests labels Sep 2, 2026
@nettle
nettle requested review from Szelethus and furtib September 2, 2026 20:35

@furtib furtib left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I was theorizing about this test in particular a lot. (How to speed it up.)
I think we have already spent way too much time on this, but when we have a relatively empty backlog, we might consider this:

I was thinking of moving the downloading out of the test action entirely and having Bazel manage it. (This way we don't necessarily need to redownload the archives for every run.)

Comment thread test/foss/foss_test_runner.py
@nettle nettle changed the title Get rid of wget in foss tests test: Get rid of wget in foss tests Sep 3, 2026
@nettle

nettle commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

I was thinking of moving the downloading out of the test action entirely and having Bazel manage it. (This way we don't necessarily need to redownload the archives for every run.)

Good thinking @furtib!
Yes, it is possible, and it is possible different ways.
One way is to make foss projects/packages as external bazel modules, see #300
And, yes, we should get back to this problem at some point...

@nettle
nettle merged commit 50a1650 into Ericsson:main Sep 3, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request test ☑️ Adding or refactoring tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants