Skip to content

test(core): kill mesh-store-shared mutants - #119

Merged
Mearman merged 1 commit into
mainfrom
chore/mutation-mesh-store-shared
Sep 14, 2026
Merged

Mearman merged 1 commit into
mainfrom
chore/mutation-mesh-store-shared

Conversation

@Mearman

@Mearman Mearman commented Sep 14, 2026

Copy link
Copy Markdown
Member

Adds dedicated coverage for mesh-store-shared.ts (mergeMessageHistories and ROOM_TOKEN_LIFETIME_MS), targeting the mutation-testing gaps tracked in #113 (sub-issue of the #64 epic).

Fixes #113

Covers mergeMessageHistories's append/union/no-duplicate/no-mutation
behaviour across single and batched incoming entries, and asserts
ROOM_TOKEN_LIFETIME_MS's exact value now that it's a real exported
constant rather than an inline literal.
@Mearman
Mearman marked this pull request as ready for review September 14, 2026 18:39
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review Completed 2026-09-14T18:42:53.751585Z 0957b16 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Mearman

Mearman commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 0957b1678d

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@Mearman
Mearman merged commit d9a5c4d into main Sep 14, 2026
6 checks passed
@Mearman
Mearman deleted the chore/mutation-mesh-store-shared branch September 14, 2026 18:55
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.21.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raise src/core/mesh-store-shared.ts mutation score to 80%

1 participant