test(bridge): widen blockPort's EADDRINUSE retry window - #99
Merged
Merged
Conversation
The prior 5-attempt/50ms budget (~250ms total) still wasn't always enough against a genuinely sustained ephemeral-port collision on a loaded CI runner -- two separate mutation-testing dry runs hit an uncaught EADDRINUSE from blockPort exhausting its retries. Widen to 10 attempts at 100ms (~1s total) to give real contention more room to clear before giving up for real.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 2.21.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two separate mutation-testing dry runs (against the newly-expanded 14-file matrix) hit an uncaught EADDRINUSE from
blockPort()inport-discovery.unit.test.tsexhausting its own retry budget -- the 5-attempt/50ms window (~250ms) added in an earlier fix for the same class of flake wasn't always enough against a genuinely sustained ephemeral-port collision on a loaded runner. Widens to 10 attempts at 100ms (~1s total).