Spend - Reconciliation - All expenses option is hidden in IOU report but shown on Spend - #100671
Closed
dukenv0307 wants to merge 3 commits into
Closed
Spend - Reconciliation - All expenses option is hidden in IOU report but shown on Spend#100671dukenv0307 wants to merge 3 commits into
dukenv0307 wants to merge 3 commits into
Conversation
dukenv0307
marked this pull request as ready for review
September 9, 2026 03:06
melvin-bot
Bot
requested review from
ZhenjaHorbach
and removed request for
a team
September 9, 2026 03:06
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
JmillsExpensify
and removed request for
a team
September 9, 2026 03:06
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf0e93e891
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
JmillsExpensify
approved these changes
Sep 9, 2026
JmillsExpensify
left a comment
Contributor
There was a problem hiding this comment.
All makes sense to me.
Contributor
Author
|
@ZhenjaHorbach could you pls review it? |
Contributor
|
Will check after 30 minutes! |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-09-09.13.36.46.movAndroid: mWeb Chrome2026-09-09.13.31.32.moviOS: HybridApp2026-09-09.13.36.46.moviOS: mWeb SafariIMG_2879.MP4MacOS: Chrome / Safari2026-09-09.13.29.08.mov |
ZhenjaHorbach
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Hide Reconciliation - All Expenses in the Search export menu when any selected row is a P2P expense, since that isn't workspace card spend.
Fixed Issues
$ #100644
PROPOSAL:
Tests
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-09.at.10.02.10.mov