Skip to content

fix: show the correct error for a single folder attachment - #100706

Open
chrispader wants to merge 1 commit into
Expensify:mainfrom
margelo:@chrispader/fix/single-folder-attachment-error
Open

fix: show the correct error for a single folder attachment#100706
chrispader wants to merge 1 commit into
Expensify:mainfrom
margelo:@chrispader/fix/single-folder-attachment-error

Conversation

@chrispader

@chrispader chrispader commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Dragging a single folder into the attachment picker currently shows the generic corrupted-file error even though the app identifies it as a folder. The folder-specific message is only selected when the validation state marks the selection as multiple files. This PR uses the folder-specific error for both single- and multi-item selections and adds focused regression coverage.

Explanation of Change

This originated while re-evaluating the unfinished attachment-validation work in #85751. Most of that work was later covered by #86189, which corrected receipt attachment validation, #93234, which made multi-file validation sequential and cleaned up object URLs, and #92236, which expanded useFilesValidation coverage. Related fixes in #96024 and #96940 also addressed HEIC conversion failures and file snapshot reliability. Comparing those changes with the current implementation exposed one remaining gap: getFileValidationErrorText() only mapped FOLDER_NOT_ALLOWED to the folder-specific copy during multi-file validation.

This change moves that mapping into the common error switch so the result no longer depends on the number of selected items. Unit tests cover both a single folder and a folder in a multi-item selection.

Fixed Issues

$ #100707
PROPOSAL: N/A

Tests

  1. Sign in on desktop web and open any report.
  2. Drag a single folder into the report composer.
  3. Verify an Attachment error modal appears with Uploading a folder is not allowed. Please try a different file.
  4. Verify the generic corrupted-file message does not appear.
  5. Drag a folder and a valid file into the report composer together.
  6. Verify the same folder-specific error appears.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline.
  2. Repeat steps 1–4 from Tests.
  3. Verify the same folder-specific error appears.

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Pending manual verification.

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@chrispader

Copy link
Copy Markdown
Contributor Author

@MelvinBot create a GH issue for this PR and assign me to it. Update the PR description to link to this issue.

@MelvinBot

MelvinBot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Done — created #100707 and assigned chrispader.

Issue: Single folder attachment shows the generic corrupted-file error instead of the folder-specific error

I also updated this PR description:

  • ### Fixed Issues now links the new issue.
  • Checked the "I linked the correct issue" box in the author checklist.

I searched both Expensify/App and Expensify/Expensify for open and recently closed duplicates and found none.


view run · view recording

@chrispader
chrispader marked this pull request as ready for review September 9, 2026 12:30
@chrispader
chrispader requested review from a team as code owners September 9, 2026 12:30
@melvin-bot
melvin-bot Bot requested review from heyjennahay and ikevin127 and removed request for a team September 9, 2026 12:30
@melvin-bot

melvin-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 9, 2026 12:30
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T12:40:29.880401Z 3aa1f54 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants