Update token on 19-digit long coercion in isExpectedNumberIntToken - #890
Open
Sahana2524 wants to merge 1 commit into
Open
Update token on 19-digit long coercion in isExpectedNumberIntToken#890Sahana2524 wants to merge 1 commit into
long coercion in isExpectedNumberIntToken#890Sahana2524 wants to merge 1 commit into
Conversation
🧪 Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isExpectedNumberIntToken()skips the token-count update for one integer-length branch:len == 19in-long-range case sets_currTokendirectly, while the <=9, <=18 and BigInteger branches (and 2.x) all go through_updateToken()longtoVALUE_NUMBER_INTis not counted, leavingcurrentTokenCount()and themaxTokenCountread constraint short for those valuesRouted it through
_updateToken()like the sibling branches; no effect when token counting is off.