fix(usage): drop the app-wide quota banner on the usage dashboard - #8512
talissoncosta wants to merge 1 commit into
Conversation
The dashboard carries its own over-limit banner, so both appeared, one under the other, saying the same thing. The app-wide one cannot reach the detail the page has, so the page keeps its own. Only hidden where the new dashboard renders, so the legacy usage page keeps the banner it has always had. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe change adds exact route matching and exports Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change is narrowly scoped to route matching and duplicate banner suppression, with no unresolved merge-blocking risk identified. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Docker builds report
|
✅ private-cloud · depot-ubuntu-latest-16 — run #20402 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20402 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #20402 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-16 — run #20402 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #8183
OrganisationLimitrenders app-wide fromApp, so on the new usage dashboard it sat directly above the page's own over-limit banner, both saying the organisation is over its quota. The app-wide one cannot tell whether overage charges actually apply, so it hedges with "automated billing for the overages may apply"; the page can be specific. The page keeps its banner, the app-wide one is hidden there.Only where the new dashboard renders, so the legacy usage page is untouched.
isOrganisationUsagejoinsisAllowedWhileBlockedinweb/routePaths, which exists so a component can match a path without importingweb/routes, which importsApp.This is what we would like to prevent:
How did you test this code?
web/__tests__/routePaths.test.tscovers the new matcher, including that a path nested under the usage page does not match.By hand against a local API: on the usage dashboard with the organisation over its limit, only the page's banner shows; off the usage route it still appears; with
usage_dashboardoff the legacy page still shows it.