Skip to content

fix: Restrict size of hidden values - #8531

Open
matthewelwell wants to merge 1 commit into
mainfrom
fix/hidden-value-overflow
Open

matthewelwell wants to merge 1 commit into
mainfrom
fix/hidden-value-overflow

Conversation

@matthewelwell

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Display hidden values as static length.

Note: this is just a quick fix for the UI nastiness, but there is likely a more permanent solution (e.g. remove the field from the UI, and API entirely).

How did you test this code?

Ran FE locally.

Before:

image

After:

image

@matthewelwell
matthewelwell requested a review from a team as a code owner September 15, 2026 09:16
@matthewelwell
matthewelwell requested review from talissoncosta and removed request for a team September 15, 2026 09:16
@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Sep 15, 2026 9:17am UTC
flagsmith-frontend-staging Ready Ready Preview Sep 15, 2026 9:17am UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Sep 15, 2026 9:17am UTC

Request Review

@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Sep 15, 2026
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e99e116f-4dde-4871-9880-64687c2cc6f2

📥 Commits

Reviewing files that changed from the base of the PR and between e2fb680 and eb561ad.

📒 Files selected for processing (1)
  • frontend/web/components/modals/CreateEditIntegrationModal.tsx

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Read-only hidden integration fields now display **********. The mask no longer uses the stored value to determine its length.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to eb561

The fixed placeholder addresses the reported overlap without exposing the stored hidden value or its length.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-8531 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-8531 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8531 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-8531 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8531 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-8531 Finished ✅ Results

@github-actions github-actions Bot added the fix label Sep 15, 2026
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-16 — run #20453 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  49.1 seconds
commit  eb561ad
info  🔄 Run: #20453 (attempt 1)

🗂️ Previous results
✅ oss · depot-ubuntu-latest-arm-16 — run #20453 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  45.8 seconds
commit  eb561ad
info  🔄 Run: #20453 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20453 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  4.5 seconds
commit  eb561ad
info  🔄 Run: #20453 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #20453 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  41.5 seconds
commit  eb561ad
info  🔄 Run: #20453 (attempt 1)

@github-actions

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant