ci: scope uv-lock pre-commit hooks to their project directories - #8534
matthewelwell wants to merge 2 commits into
Conversation
The uv-lock hook published by astral-sh/uv-pre-commit anchors `files` at the repository root, assuming the project sits there. Ours are in subdirectories, so neither `api-lockcheck` nor `mcp-lockcheck` has ever matched a file — both report "(no files to check) Skipped" in every run, including CI. The result is that we have no lockfile validation at all. Overriding `files` per hook scopes each to the project it checks. Both now execute and pass under `make lint`, and fail on a stale lockfile rather than skipping. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to The MCP lockcheck now targets the intended project files, with no identified merge-blocking impact. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Docker builds report
|
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20469 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
🗂️ Previous results✅ oss · depot-ubuntu-latest-arm-16 — run #20469 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
✅ private-cloud · depot-ubuntu-latest-16 — run #20469 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-16 — run #20469 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
Add correct directory scoping to
api|mcp-lockcheckhooks in pre-commit.The
uv-lockhook published by astral-sh/uv-pre-commit anchorsfilesat the repository root,assuming the project sits there:
Ours are at
api/uv.lockandmcp/uv.lock, so neither instance matches anything — both report(no files to check) Skippedon every run, locally and in CI.Before
Link: https://results.pre-commit.ci/run/github/136163130/1789563046.t0oTcPlPT7u8Q1_SGJWinw
After
Link: (see workflows on this PR)