Correct algorithm to pass testbench - #90
Open
RechieKho wants to merge 11 commits into
Open
Conversation
Author
|
And hopefully this patch could be integrated and released soon, because I kind of want to write a voxel engine, haha 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #49
So I have investigated throughout the issue. This is the summary of what happened:
int i = (int)ceil((maxbit + 1) / 8.0f)in for loop ofcompute3D_ET_LUT_encodecausing one off error. While for decoder, there are not non-pre shifted LUT, and using the pre-shifted LUT under typical LUT algorithm causes the error. I supposed for decoder case, it is not as simple as encoder case where y and z component is just x component LUT table shifted by 1 or 2 correspondingly, since for decoder, the shifting is done before passing intomorton3D_GetThirdBits. Thus, a simple LUT generate is written and ran to generate the unshifted LUT for decoding LUTs.Hopefully what I did is correct. I supposed this patch is somewhat important since LUT implementation is defaulted to be the fallback, and a buggy algorithm as default is kind of hard to be ignored.