ci: finish the action bumps the three conflicting Dependabot PRs could not land - #73
Merged
Merged
Conversation
…d not land #65 and #66 merged cleanly; #67, #68 and #69 each rebased onto a stale master and then conflicted with each other because they all edit the same workflow files. Applying the three remaining bumps together avoids the rebase-conflict-rebase loop. setup-node v4 and checkout v4 were also the actions the runner warned about by name — they target the deprecated Node 20 and were being forced onto Node 24. Closes #67, #68, #69. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The changes are straightforward action-version bumps across workflows with no apparent configuration or behavioral breakage introduced in the updated YAML.
Pull request overview
This PR consolidates and completes the remaining GitHub Actions dependency bumps that previously conflicted across multiple Dependabot PRs, updating the repository’s CI, publish, and Docker publish workflows to newer major action versions (notably moving off deprecated Node 20-based action runtimes).
Changes:
- Bump
actions/setup-nodefromv4tov7across CI and npm publish workflows. - Bump
docker/build-push-actionfromv6tov7anddocker/metadata-actionfromv5tov6in the Docker publish workflow.
File summaries
| File | Description |
|---|---|
| .github/workflows/publish.yml | Updates actions/setup-node to v7 for the npm publish workflow. |
| .github/workflows/docker-publish.yml | Updates Docker build/publish actions to their latest major versions (metadata-action@v6, build-push-action@v7). |
| .github/workflows/ci.yml | Updates actions/setup-node to v7 across all CI jobs (including the Node 20 compatibility job). |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/checkout@v4→v7(#65) anddocker/setup-buildx-action@v3→v4(#66) merged cleanly. The remaining three — #67 (setup-node4→7), #68 (build-push-action6→7), #69 (metadata-action5→6) — each branched off a stale master and then conflicted with each other, since all three edit the same workflow files. Landing them as one commit avoids the rebase-conflict-rebase loop.setup-node@v4andcheckout@v4were also the two actions the runner called out by name: they target the deprecated Node 20 and were being silently forced onto Node 24.Closes #67
Closes #68
Closes #69