Skip to content

- Fix list box theme colors - #579

Merged
x64-dev merged 1 commit into
GeneralsOnlineDevelopmentTeam:mainfrom
Jaredl-Dev:fix/listbox-theme-colors
Aug 26, 2026
Merged

- Fix list box theme colors#579
x64-dev merged 1 commit into
GeneralsOnlineDevelopmentTeam:mainfrom
Jaredl-Dev:fix/listbox-theme-colors

Conversation

@Jaredl-Dev

Copy link
Copy Markdown

Removes the hardcoded translucent blue overlay from list box rendering so colors supplied by WND files are displayed unchanged.

Generals Online previously disabled the lobby list while searching or showing no results, which exposes the scrollbar’s yellow disabled-state styling once the overlay is removed. The list now remains enabled, only displays the searching status when empty, and accepts Join actions only for rows containing valid lobby IDs.

Validation

  • Release build passes.
  • Tested list box colors in LAN and Online Lobbies with Operation Firestorm and Contra mods.
  • Tested online and game lobbies.

@github-actions

Copy link
Copy Markdown

⚠️ Title/Commit Validation Failed

Invalid PR title:

  • - Fix list box theme colors

Invalid commit messages:

type: Description
type(scope): Description

Allowed types: bugfix, build, chore, ci, docs, fix, feat, perf, refactor, revert, style, test, tweak, unify

See CONTRIBUTING.md for details.

@Jaredl-Dev

Copy link
Copy Markdown
Author

Here is an example of what this PR fixes:

sshot_20260824_185442_253 sshot_20260824_185330_393

@x64-dev
x64-dev merged commit 3010fc0 into GeneralsOnlineDevelopmentTeam:main Aug 26, 2026
4 of 5 checks passed
@Jaredl-Dev
Jaredl-Dev deleted the fix/listbox-theme-colors branch August 26, 2026 22:20
x64-dev added a commit that referenced this pull request Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants