Skip to content

fix(SIGN): rename signe struct - #192

Open
BenPinet wants to merge 1 commit into
v18from
feat/put_sign_struct_in_caps
Open

fix(SIGN): rename signe struct#192
BenPinet wants to merge 1 commit into
v18from
feat/put_sign_struct_in_caps

Conversation

@BenPinet

@BenPinet BenPinet commented Aug 3, 2026

Copy link
Copy Markdown
Member

No description provided.

@BenPinet
BenPinet requested a review from BotellaA August 3, 2026 14:43
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 7 concern(s)
  • src/geode/inspector/inspection/criterion/negative_elements/solid_negative_elements.cpp:42:9: warning: [google-explicit-constructor]

    single-argument constructors must be marked explicit to avoid unintentional implicit conversions

       42 |         Impl( const SolidMesh< dimension >& mesh ) : mesh_( mesh ) {}
          |         ^
          |         explicit 
  • src/geode/inspector/inspection/criterion/negative_elements/solid_negative_elements.cpp:44:9: warning: [modernize-use-nodiscard]

    function 'mesh_has_negative_elements' should be marked [[nodiscard]]

       44 |         bool mesh_has_negative_elements() const
          |         ^
          |         [[nodiscard]] 
  • src/geode/inspector/inspection/criterion/negative_elements/solid_negative_elements.cpp:56:9: warning: [modernize-use-nodiscard]

    function 'negative_polyhedra' should be marked [[nodiscard]]

       56 |         InspectionIssues< index_t > negative_polyhedra() const
          |         ^
          |         [[nodiscard]] 
  • src/geode/inspector/inspection/criterion/negative_elements/solid_negative_elements.cpp:73:9: warning: [modernize-use-nodiscard]

    function 'polyhedron_has_negative_volume' should be marked [[nodiscard]]

       73 |         bool polyhedron_has_negative_volume( index_t polyhedron_id ) const
          |         ^
          |         [[nodiscard]] 
  • src/geode/inspector/inspection/criterion/negative_elements/surface_negative_elements.cpp:43:9: warning: [google-explicit-constructor]

    single-argument constructors must be marked explicit to avoid unintentional implicit conversions

       43 |         Impl( const SurfaceMesh< dimension >& mesh ) : mesh_( mesh ) {}
          |         ^
          |         explicit 
  • src/geode/inspector/inspection/criterion/negative_elements/surface_negative_elements.cpp:45:9: warning: [modernize-use-nodiscard]

    function 'mesh_has_negative_elements' should be marked [[nodiscard]]

       45 |         bool mesh_has_negative_elements() const
          |         ^
          |         [[nodiscard]] 
  • src/geode/inspector/inspection/criterion/negative_elements/surface_negative_elements.cpp:61:9: warning: [modernize-use-nodiscard]

    function 'negative_polygons' should be marked [[nodiscard]]

       61 |         InspectionIssues< index_t > negative_polygons() const
          |         ^
          |         [[nodiscard]] 

Have any feedback or feature suggestions? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants