Skip to content

fix(MakeTuple): remove std::make_tuple and std::make_pair - #1316

Open
BenPinet wants to merge 3 commits into
v18from
fix/remove_make_pair_and_tuple
Open

fix(MakeTuple): remove std::make_tuple and std::make_pair#1316
BenPinet wants to merge 3 commits into
v18from
fix/remove_make_pair_and_tuple

Conversation

@BenPinet

@BenPinet BenPinet commented Aug 6, 2026

Copy link
Copy Markdown
Member

No description provided.

@BenPinet
BenPinet requested a review from BotellaA August 6, 2026 12:09
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 537 concern(s)
  • include/geode/geometry/detail/aabb_impl.hpp:70:9: warning: [google-explicit-constructor]

    single-argument constructors must be marked explicit to avoid unintentional implicit conversions

       70 |         Impl( absl::Span< const BoundingBox< dimension > > bboxes )
          |         ^
          |         explicit 
  • include/geode/geometry/detail/aabb_impl.hpp:107:13: warning: [bugprone-easily-swappable-parameters]

    2 adjacent parameters of 'get_recursive_iterators' of similar type ('index_t') are easily swapped by mistake

      107 |             index_t node_index, index_t element_begin, index_t element_end )
          |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:107:21: note: the first parameter in the range is 'node_index'
      107 |             index_t node_index, index_t element_begin, index_t element_end )
          |                     ^~~~~~~~~~
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:107:41: note: the last parameter in the range is 'element_begin'
      107 |             index_t node_index, index_t element_begin, index_t element_end )
          |                                         ^~~~~~~~~~~~~
  • include/geode/geometry/detail/aabb_impl.hpp:109:22: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      109 |             Iterator it;
          |                      ^
  • include/geode/geometry/detail/aabb_impl.hpp:140:24: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      140 |             const auto it = get_recursive_iterators(
          |                        ^
  • include/geode/geometry/detail/aabb_impl.hpp:165:24: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      165 |             const auto it = get_recursive_iterators(
          |                        ^
  • include/geode/geometry/detail/aabb_impl.hpp:181:14: warning: [readability-function-cognitive-complexity]

    function 'closest_element_box_recursive' has cognitive complexity of 13 (threshold 10)

      181 |         void closest_element_box_recursive( const Point< dimension >& query,
          |              ^
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:197:13: note: +1, including nesting penalty of 0, nesting level increased to 1
      197 |             if( is_leaf( element_begin, element_end ) )
          |             ^
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:202:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      202 |                 if( cur_distance < distance )
          |                 ^
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:218:13: note: +1, including nesting penalty of 0, nesting level increased to 1
      218 |             if( distance_left < distance_right )
          |             ^
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:220:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      220 |                 if( distance_left < distance )
          |                 ^
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:226:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      226 |                 if( distance_right < distance )
          |                 ^
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:233:13: note: +1, nesting level increased to 1
      233 |             else
          |             ^
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:235:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      235 |                 if( distance_right < distance )
          |                 ^
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:241:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      241 |                 if( distance_left < distance )
          |                 ^
  • include/geode/geometry/detail/aabb_impl.hpp:181:14: warning: [readability-function-size]

    function 'closest_element_box_recursive' exceeds recommended size/complexity thresholds

      181 |         void closest_element_box_recursive( const Point< dimension >& query,
          |              ^
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:181:14: note: 7 parameters (threshold 4)
  • include/geode/geometry/detail/aabb_impl.hpp:209:24: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      209 |             const auto it = get_recursive_iterators(
          |                        ^
  • include/geode/geometry/detail/aabb_impl.hpp:251:14: warning: [readability-function-size]

    function 'self_intersect_recursive' exceeds recommended size/complexity thresholds

      251 |         bool self_intersect_recursive( index_t node_index1,
          |              ^
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:251:14: note: 7 parameters (threshold 4)
  • include/geode/geometry/detail/aabb_impl.hpp:299:28: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      299 |                 const auto it = get_recursive_iterators(
          |                            ^
  • include/geode/geometry/detail/aabb_impl.hpp:311:24: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      311 |             const auto it = get_recursive_iterators(
          |                        ^
  • include/geode/geometry/detail/aabb_impl.hpp:325:14: warning: [readability-function-size]

    function 'other_intersect_recursive' exceeds recommended size/complexity thresholds

      325 |         bool other_intersect_recursive( index_t node_index1,
          |              ^
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:325:14: note: 8 parameters (threshold 4)
  • include/geode/geometry/detail/aabb_impl.hpp:363:28: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      363 |                 const auto it = get_recursive_iterators(
          |                            ^
  • include/geode/geometry/detail/aabb_impl.hpp:375:24: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      375 |             const auto it = get_recursive_iterators(
          |                        ^
  • include/geode/geometry/detail/aabb_impl.hpp:389:14: warning: [readability-function-size]

    function 'generic_intersect_recursive' exceeds recommended size/complexity thresholds

      389 |         bool generic_intersect_recursive( const BOX_FILTER& box_filter,
          |              ^
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:389:14: note: 5 parameters (threshold 4)
  • include/geode/geometry/detail/aabb_impl.hpp:412:24: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      412 |             const auto it = get_recursive_iterators(
          |                        ^
  • include/geode/geometry/detail/aabb_impl.hpp:431:28: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      431 |                 const auto it = get_recursive_iterators(
          |                            ^
  • include/geode/geometry/detail/aabb_impl.hpp:449:14: warning: [readability-function-size]

    function 'containing_boxes_recursive' exceeds recommended size/complexity thresholds

      449 |         void containing_boxes_recursive( index_t node_index,
          |              ^
    /__w/OpenGeode/OpenGeode/include/geode/geometry/detail/aabb_impl.hpp:449:14: note: 5 parameters (threshold 4)
  • include/geode/geometry/detail/aabb_impl.hpp:469:24: warning: [readability-identifier-length]

    variable name 'it' is too short, expected at least 3 characters

      469 |             const auto it = get_recursive_iterators(
          |                        ^
  • include/geode/model/representation/builder/detail/copy.hpp:48:1: warning: [modernize-concat-nested-namespaces]

    nested namespaces can be concatenated

       48 | namespace geode
          | ^~~~~~~~~~~~~~~
       49 | {
          | ~
       50 |     namespace detail
          |     ~~~~~~~~~~~~~~~~
          |     namespace geode::detail
  • include/geode/model/representation/builder/detail/copy.hpp:55:14: warning: [readability-function-cognitive-complexity]

    function 'copy_corner_components' has cognitive complexity of 12 (threshold 10)

       55 |         void copy_corner_components(
          |              ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:58:13: note: +1, including nesting penalty of 0, nesting level increased to 1
       58 |             for( const auto& corner : from.corners() )
          |             ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:60:17: note: +2, including nesting penalty of 1, nesting level increased to 2
       60 |                 if( mapping.has_mapping_input( corner.id() ) )
          |                 ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:64:25: note: +3, including nesting penalty of 2, nesting level increased to 3
       64 |                         ? builder_to.add_corner( id, corner.mesh().impl_name() )
          |                         ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:67:17: note: +1, nesting level increased to 2
       67 |                 else
          |                 ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:71:29: note: +3, including nesting penalty of 2, nesting level increased to 3
       71 |                             ? builder_to.add_corner( corner.mesh().impl_name() )
          |                             ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:76:17: note: +2, including nesting penalty of 1, nesting level increased to 2
       76 |                 if( const auto name = corner.name() )
          |                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:62:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

       62 |                     const auto& id = mapping.in2out( corner.id() );
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:69:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

       69 |                     const auto& id =
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:75:29: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

       75 |                 const auto& id = mapping.in2out( corner.id() );
          |                             ^
  • include/geode/model/representation/builder/detail/copy.hpp:85:14: warning: [readability-function-cognitive-complexity]

    function 'copy_line_components' has cognitive complexity of 12 (threshold 10)

       85 |         void copy_line_components(
          |              ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:88:13: note: +1, including nesting penalty of 0, nesting level increased to 1
       88 |             for( const auto& line : from.lines() )
          |             ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:90:17: note: +2, including nesting penalty of 1, nesting level increased to 2
       90 |                 if( mapping.has_mapping_input( line.id() ) )
          |                 ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:94:25: note: +3, including nesting penalty of 2, nesting level increased to 3
       94 |                         ? builder_to.add_line( id, line.mesh().impl_name() )
          |                         ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:97:17: note: +1, nesting level increased to 2
       97 |                 else
          |                 ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:101:29: note: +3, including nesting penalty of 2, nesting level increased to 3
      101 |                             ? builder_to.add_line( line.mesh().impl_name() )
          |                             ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:106:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      106 |                 if( const auto name = line.name() )
          |                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:92:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

       92 |                     const auto& id = mapping.in2out( line.id() );
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:99:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

       99 |                     const auto& id =
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:105:29: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      105 |                 const auto& id = mapping.in2out( line.id() );
          |                             ^
  • include/geode/model/representation/builder/detail/copy.hpp:115:14: warning: [readability-function-cognitive-complexity]

    function 'copy_surface_components' has cognitive complexity of 12 (threshold 10)

      115 |         void copy_surface_components(
          |              ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:118:13: note: +1, including nesting penalty of 0, nesting level increased to 1
      118 |             for( const auto& surface : from.surfaces() )
          |             ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:120:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      120 |                 if( mapping.has_mapping_input( surface.id() ) )
          |                 ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:124:25: note: +3, including nesting penalty of 2, nesting level increased to 3
      124 |                         ? builder_to.add_surface(
          |                         ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:128:17: note: +1, nesting level increased to 2
      128 |                 else
          |                 ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:131:42: note: +3, including nesting penalty of 2, nesting level increased to 3
      131 |                                          ? builder_to.add_surface(
          |                                          ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:137:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      137 |                 if( const auto name = surface.name() )
          |                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:122:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      122 |                     const auto& id = mapping.in2out( surface.id() );
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:130:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      130 |                     const auto& id = ModelFrom::dim == BuilderTo::dim
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:136:29: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      136 |                 const auto& id = mapping.in2out( surface.id() );
          |                             ^
  • include/geode/model/representation/builder/detail/copy.hpp:146:14: warning: [readability-function-cognitive-complexity]

    function 'copy_block_components' has cognitive complexity of 12 (threshold 10)

      146 |         void copy_block_components(
          |              ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:149:13: note: +1, including nesting penalty of 0, nesting level increased to 1
      149 |             for( const auto& block : from.blocks() )
          |             ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:151:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      151 |                 if( mapping.has_mapping_input( block.id() ) )
          |                 ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:155:25: note: +3, including nesting penalty of 2, nesting level increased to 3
      155 |                         ? builder_to.add_block( id, block.mesh().impl_name() )
          |                         ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:158:17: note: +1, nesting level increased to 2
      158 |                 else
          |                 ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:162:29: note: +3, including nesting penalty of 2, nesting level increased to 3
      162 |                             ? builder_to.add_block( block.mesh().impl_name() )
          |                             ^
    /__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:167:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      167 |                 if( const auto name = block.name() )
          |                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:153:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      153 |                     const auto& id = mapping.in2out( block.id() );
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:160:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      160 |                     const auto& id =
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:166:29: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      166 |                 const auto& id = mapping.in2out( block.id() );
          |                             ^
  • include/geode/model/representation/builder/detail/copy.hpp:183:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      183 |                     const auto& id = mapping.in2out( model_boundary.id() );
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:188:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      188 |                     const auto& id = builder_to.add_model_boundary();
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:191:29: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      191 |                 const auto& id = mapping.in2out( model_boundary.id() );
          |                             ^
  • include/geode/model/representation/builder/detail/copy.hpp:209:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      209 |                     const auto& id = mapping.in2out( corner_collection.id() );
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:214:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      214 |                     const auto& id = builder_to.add_corner_collection();
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:217:29: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      217 |                 const auto& id = mapping.in2out( corner_collection.id() );
          |                             ^
  • include/geode/model/representation/builder/detail/copy.hpp:235:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      235 |                     const auto& id = mapping.in2out( line_collection.id() );
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:240:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      240 |                     const auto& id = builder_to.add_line_collection();
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:243:29: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      243 |                 const auto& id = mapping.in2out( line_collection.id() );
          |                             ^
  • include/geode/model/representation/builder/detail/copy.hpp:261:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      261 |                     const auto& id = mapping.in2out( surface_collection.id() );
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:266:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      266 |                     const auto& id = builder_to.add_surface_collection();
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:269:29: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      269 |                 const auto& id = mapping.in2out( surface_collection.id() );
          |                             ^
  • include/geode/model/representation/builder/detail/copy.hpp:287:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      287 |                     const auto& id = mapping.in2out( block_collection.id() );
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:292:33: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      292 |                     const auto& id = builder_to.add_block_collection();
          |                                 ^
  • include/geode/model/representation/builder/detail/copy.hpp:295:29: warning: [readability-identifier-length]

    variable name 'id' is too short, expected at least 3 characters

      295 |                 const auto& id = mapping.in2out( block_collection.id() );
          |                             ^
  • include/geode/model/representation/builder/detail/copy.hpp:307:35: warning: [cppcoreguidelines-missing-std-forward]

    forwarding reference parameter 'range' is never forwarded inside the function body

      307 |             clone_meshes( Range&& range, index_t nb_components )
          |                                   ^
  • include/geode/model/representation/builder/detail/copy.hpp:330:28: warning: [readability-identifier-length]

    parameter name 'to' is too short, expected at least 3 characters

      330 |             const ModelTo& to,
          |                            ^
  • include/geode/model/representation/builder/detail/copy.hpp:345:28: warning: [readability-identifier-length]

    parameter name 'to' is too short, expected at least 3 characters

      345 |             const ModelTo& to,
          |                            ^
  • include/geode/model/representation/builder/detail/copy.hpp:360:28: warning: [readability-identifier-length]

    parameter name 'to' is too short, expected at least 3 characters

      360 |             const ModelTo& to,
          |                            ^
  • include/geode/model/representation/builder/detail/copy.hpp:375:28: warning: [readability-identifier-length]

    parameter name 'to' is too short, expected at least 3 characters

      375 |             const ModelTo& to,
          |                            ^
  • include/geode/model/representation/builder/detail/copy.hpp:397:29: warning: [readability-identifier-length]

    parameter name 'v' is too short, expected at least 3 characters

      397 |                     index_t v ) {
          |                             ^
  • src/geode/geometry/basic_objects/triangle.cpp:41:12: warning: [cppcoreguidelines-pro-type-member-init]

    constructor does not initialize these fields: lengths

       41 |     struct PivotNormalResult
          |            ^
       42 |     {
       43 |         geode::local_index_t pivot{ geode::NO_LID };
       44 |         geode::Vector3D normal{ { 0, 0, 0 } };
       45 |         std::array< double, 3 > lengths;
          |                                        
          |                                        {}
  • src/geode/geometry/basic_objects/triangle.cpp:48:40: warning: [readability-function-cognitive-complexity]

    function 'simple_pivot_and_normal' has cognitive complexity of 11 (threshold 10)

       48 |     std::optional< PivotNormalResult > simple_pivot_and_normal(
          |                                        ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/triangle.cpp:52:9: note: +1, including nesting penalty of 0, nesting level increased to 1
       52 |         for( const auto pivot : geode::LRange{ 3 } )
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/triangle.cpp:54:46: note: +2, including nesting penalty of 1, nesting level increased to 2
       54 |             const auto next = pivot + 1 == 3 ? 0 : pivot + 1;
          |                                              ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/triangle.cpp:57:13: note: +2, including nesting penalty of 1, nesting level increased to 2
       57 |             if( result->lengths[pivot] < geode::GLOBAL_EPSILON )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/triangle.cpp:62:42: note: +2, including nesting penalty of 1, nesting level increased to 2
       62 |             const auto prev = pivot == 0 ? 2 : pivot - 1;
          |                                          ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/triangle.cpp:65:13: note: +2, including nesting penalty of 1, nesting level increased to 2
       65 |             if( length1 < geode::GLOBAL_EPSILON )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/triangle.cpp:72:13: note: +2, including nesting penalty of 1, nesting level increased to 2
       72 |             if( length > geode::GLOBAL_ANGULAR_EPSILON )
          |             ^
  • src/geode/geometry/basic_objects/triangle.cpp:117:47: warning: [cppcoreguidelines-avoid-magic-numbers]

    1. is a magic number; consider replacing it with a named constant
      117 |         return ( point0 + point1 + point2 ) / 3.;
          |                                               ^
  • src/geode/geometry/basic_objects/triangle.cpp:192:20: warning: [readability-identifier-length]

    variable name 'e1' is too short, expected at least 3 characters

      192 |         const auto e1 = longest_e == 2 ? 0 : longest_e + 1;
          |                    ^
  • src/geode/geometry/basic_objects/triangle.cpp:194:20: warning: [readability-identifier-length]

    variable name 'e2' is too short, expected at least 3 characters

      194 |         const auto e2 = e1 == 2 ? 0 : e1 + 1;
          |                    ^
  • src/geode/geometry/basic_objects/triangle.cpp:201:36: warning: [readability-math-missing-parentheses]

    '*' has higher precedence than '+'; add parentheses to explicitly specify the order of operations

      201 |             const auto new_point = point0 * ( 1. - ratio ) + point1 * ratio;
          |                                    ^~~~~~~~~~~~~~~~~~~~~~~
          |                                    (                      )
  • src/geode/geometry/basic_objects/triangle.cpp:201:62: warning: [readability-math-missing-parentheses]

    '*' has higher precedence than '+'; add parentheses to explicitly specify the order of operations

      201 |             const auto new_point = point0 * ( 1. - ratio ) + point1 * ratio;
          |                                                              ^~~~~~~~~~~~~~~
          |                                                              (             )
  • src/geode/geometry/bounding_box.cpp:100:19: warning: [readability-math-missing-parentheses]

    '*' has higher precedence than '+'; add parentheses to explicitly specify the order of operations

      100 |                 + segment_extent * std::fabs( segment_direction.value( i ) );
          |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          |                   (                                                         )
  • src/geode/geometry/bounding_box.cpp:130:24: warning: [readability-identifier-length]

    variable name 'ii' is too short, expected at least 3 characters

      130 |             const auto ii = i == 2 ? 0 : i + 1;
          |                        ^
  • src/geode/geometry/bounding_box.cpp:155:26: warning: [readability-math-missing-parentheses]

    '*' has higher precedence than '+'; add parentheses to explicitly specify the order of operations

      155 |         const auto rhs = box_half_extent.value( 0 )
          |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~
          |                          (
      156 |                              * std::fabs( line.direction().value( 1 ) )
          |                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          |                                                                        )
  • src/geode/geometry/bounding_box.cpp:157:28: warning: [readability-math-missing-parentheses]

    '*' has higher precedence than '+'; add parentheses to explicitly specify the order of operations

      157 |                          + box_half_extent.value( 1 )
          |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~
          |                            (
      158 |                                * std::fabs( line.direction().value( 0 ) );
          |                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          |                                                                          )
  • src/geode/geometry/bounding_box.cpp:238:9: warning: [bugprone-easily-swappable-parameters]

    2 adjacent parameters of 'BoundingBox' of similar type ('Point') are easily swapped by mistake

      238 |         Point< dimension > min, Point< dimension > max )
          |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:238:28: note: the first parameter in the range is 'min'
      238 |         Point< dimension > min, Point< dimension > max )
          |                            ^~~
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:238:52: note: the last parameter in the range is 'max'
      238 |         Point< dimension > min, Point< dimension > max )
          |                                                    ^~~
  • src/geode/geometry/bounding_box.cpp:466:51: warning: [readability-function-cognitive-complexity]

    function 'intersects<3U>' has cognitive complexity of 14 (threshold 10)

      466 |     bool opengeode_geometry_api BoundingBox< 3 >::intersects< 3 >(
          |                                                   ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:470:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      470 |         for( const auto v : LRange{ 3 } )
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:472:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      472 |             if( contains( vertices[v].get() ) )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:477:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      477 |         if( !intersects( triangle.bounding_box() ) )
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:490:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      490 |         if( !bbox_1d_projection( *this, triangle_normal )
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:498:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      498 |         for( const auto i : LRange{ 3 } )
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:509:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      509 |             if( !triangle_interval.intersects( box_interval ) )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:516:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      516 |         for( const auto i0 : LRange{ 3 } )
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:518:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      518 |             for( const auto i1 : LRange{ 3 } )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:526:17: note: +3, including nesting penalty of 2, nesting level increased to 3
      526 |                 if( !triangle_interval.intersects( box_interval ) )
          |                 ^
  • src/geode/geometry/bounding_box.cpp:516:25: warning: [readability-identifier-length]

    variable name 'i0' is too short, expected at least 3 characters

      516 |         for( const auto i0 : LRange{ 3 } )
          |                         ^
  • src/geode/geometry/bounding_box.cpp:518:29: warning: [readability-identifier-length]

    variable name 'i1' is too short, expected at least 3 characters

      518 |             for( const auto i1 : LRange{ 3 } )
          |                             ^
  • src/geode/geometry/bounding_box.cpp:537:51: warning: [readability-function-cognitive-complexity]

    function 'epsilon_intersects<3U>' has cognitive complexity of 14 (threshold 10)

      537 |     bool opengeode_geometry_api BoundingBox< 3 >::epsilon_intersects< 3 >(
          |                                                   ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:541:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      541 |         for( const auto v : LRange{ 3 } )
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:543:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      543 |             if( epsilon_contains( vertices[v].get() ) )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:548:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      548 |         if( !epsilon_intersects( triangle.bounding_box() ) )
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:561:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      561 |         if( !bbox_1d_projection( *this, triangle_normal )
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:569:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      569 |         for( const auto i : LRange{ 3 } )
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:580:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      580 |             if( !triangle_interval.epsilon_intersects( box_interval ) )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:587:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      587 |         for( const auto i0 : LRange{ 3 } )
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:589:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      589 |             for( const auto i1 : LRange{ 3 } )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/bounding_box.cpp:597:17: note: +3, including nesting penalty of 2, nesting level increased to 3
      597 |                 if( !triangle_interval.epsilon_intersects( box_interval ) )
          |                 ^
  • src/geode/geometry/bounding_box.cpp:587:25: warning: [readability-identifier-length]

    variable name 'i0' is too short, expected at least 3 characters

      587 |         for( const auto i0 : LRange{ 3 } )
          |                         ^
  • src/geode/geometry/bounding_box.cpp:589:29: warning: [readability-identifier-length]

    variable name 'i1' is too short, expected at least 3 characters

      589 |             for( const auto i1 : LRange{ 3 } )
          |                             ^
  • src/geode/geometry/bounding_box.cpp:713:34: warning: [cppcoreguidelines-avoid-magic-numbers]

    1. is a magic number; consider replacing it with a named constant
      713 |         return ( min_ + max_ ) / 2.;
          |                                  ^
  • src/geode/geometry/bounding_box.cpp:750:25: warning: [readability-identifier-length]

    variable name 'c' is too short, expected at least 3 characters

      750 |         for( const auto c : LRange{ dimension } )
          |                         ^
  • src/geode/geometry/bounding_box.cpp:768:20: warning: [readability-identifier-naming]

    invalid case style for variable 'Pmin'

      768 |         const auto Pmin = point - min_;
          |                    ^~~~
          |                    pmin
      769 |         const auto Pmax = point - max_;
      770 |         auto inner_distance = std::numeric_limits< double >::max();
      771 |         for( const auto c : LRange{ dimension } )
      772 |         {
      773 |             const auto local_distance = std::min(
      774 |                 std::fabs( Pmin.value( c ) ), std::fabs( Pmax.value( c ) ) );
          |                            ~~~~
          |                            pmin
  • src/geode/geometry/bounding_box.cpp:769:20: warning: [readability-identifier-naming]

    invalid case style for variable 'Pmax'

      769 |         const auto Pmax = point - max_;
          |                    ^~~~
          |                    pmax
      770 |         auto inner_distance = std::numeric_limits< double >::max();
      771 |         for( const auto c : LRange{ dimension } )
      772 |         {
      773 |             const auto local_distance = std::min(
      774 |                 std::fabs( Pmin.value( c ) ), std::fabs( Pmax.value( c ) ) );
          |                                                          ~~~~
          |                                                          pmax
  • src/geode/geometry/bounding_box.cpp:771:25: warning: [readability-identifier-length]

    variable name 'c' is too short, expected at least 3 characters

      771 |         for( const auto c : LRange{ dimension } )
          |                         ^
  • src/geode/geometry/bounding_box.cpp:785:25: warning: [readability-identifier-length]

    variable name 'c' is too short, expected at least 3 characters

      785 |         for( const auto c : LRange{ dimension } )
          |                         ^
  • src/geode/geometry/distance.cpp:91:9: warning: [readability-use-std-min-max]

    use std::max instead of <=

       24 |         if( area2 <= 0 )
          |         ^~~~~~~~~~~~~~~~
          |         area2 = std::max<double>(area2, 0);
       25 |         {
          |         ~
       26 |             area2 = 0;
          |             ~~~~~~~~~~
       27 |         }
          |         ~
  • src/geode/geometry/distance.cpp:98:45: warning: [readability-identifier-length]

    parameter name 'b1' is too short, expected at least 3 characters

       98 |     void get_min_edge02( double a11, double b1, std::array< double, 2 >& p )
          |                                             ^
  • src/geode/geometry/distance.cpp:98:74: warning: [readability-identifier-length]

    parameter name 'p' is too short, expected at least 3 characters

       98 |     void get_min_edge02( double a11, double b1, std::array< double, 2 >& p )
          |                                                                          ^
  • src/geode/geometry/distance.cpp:115:10: warning: [readability-function-size]

    function 'get_min_edge12' exceeds recommended size/complexity thresholds

      115 |     void get_min_edge12( double a01,
          |          ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:115:10: note: 6 parameters (threshold 4)
  • src/geode/geometry/distance.cpp:115:26: warning: [bugprone-easily-swappable-parameters]

    2 adjacent parameters of 'get_min_edge12' of similar type ('double') are easily swapped by mistake

      115 |     void get_min_edge12( double a01,
          |                          ^~~~~~~~~~~
      116 |         double a11,
          |         ~~~~~~~~~~
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:115:33: note: the first parameter in the range is 'a01'
      115 |     void get_min_edge12( double a01,
          |                                 ^~~
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:116:16: note: the last parameter in the range is 'a11'
      116 |         double a11,
          |                ^~~
  • src/geode/geometry/distance.cpp:117:16: warning: [readability-identifier-length]

    parameter name 'b1' is too short, expected at least 3 characters

      117 |         double b1,
          |                ^
  • src/geode/geometry/distance.cpp:118:9: warning: [bugprone-easily-swappable-parameters]

    2 adjacent parameters of 'get_min_edge12' of similar type ('double') are easily swapped by mistake

      118 |         double f10,
          |         ^~~~~~~~~~~
      119 |         double f01,
          |         ~~~~~~~~~~
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:118:16: note: the first parameter in the range is 'f10'
      118 |         double f10,
          |                ^~~
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:119:16: note: the last parameter in the range is 'f01'
      119 |         double f01,
          |                ^~~
  • src/geode/geometry/distance.cpp:120:34: warning: [readability-identifier-length]

    parameter name 'p' is too short, expected at least 3 characters

      120 |         std::array< double, 2 >& p )
          |                                  ^
  • src/geode/geometry/distance.cpp:122:20: warning: [readability-identifier-length]

    variable name 'h0' is too short, expected at least 3 characters

      122 |         const auto h0 = a01 + b1 - f10;
          |                    ^
  • src/geode/geometry/distance.cpp:129:24: warning: [readability-identifier-length]

    variable name 'h1' is too short, expected at least 3 characters

      129 |             const auto h1 = a11 + b1 - f01;
          |                        ^
  • src/geode/geometry/distance.cpp:142:10: warning: [readability-function-size]

    function 'get_min_interior' exceeds recommended size/complexity thresholds

      142 |     void get_min_interior( const std::array< double, 2 >& p0,
          |          ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:142:10: note: 5 parameters (threshold 4)
  • src/geode/geometry/distance.cpp:142:59: warning: [readability-identifier-length]

    parameter name 'p0' is too short, expected at least 3 characters

      142 |     void get_min_interior( const std::array< double, 2 >& p0,
          |                                                           ^
  • src/geode/geometry/distance.cpp:143:16: warning: [readability-identifier-length]

    parameter name 'h0' is too short, expected at least 3 characters

      143 |         double h0,
          |                ^
  • src/geode/geometry/distance.cpp:144:40: warning: [readability-identifier-length]

    parameter name 'p1' is too short, expected at least 3 characters

      144 |         const std::array< double, 2 >& p1,
          |                                        ^
  • src/geode/geometry/distance.cpp:145:16: warning: [readability-identifier-length]

    parameter name 'h1' is too short, expected at least 3 characters

      145 |         double h1,
          |                ^
  • src/geode/geometry/distance.cpp:146:34: warning: [readability-identifier-length]

    parameter name 'p' is too short, expected at least 3 characters

      146 |         std::array< double, 2 >& p )
          |                                  ^
  • src/geode/geometry/distance.cpp:196:42: warning: [readability-function-cognitive-complexity]

    function 'pivot_point_triangle_distance' has cognitive complexity of 44 (threshold 10)

      196 |     std::tuple< double, geode::Point3D > pivot_point_triangle_distance(
          |                                          ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:201:33: note: +1, including nesting penalty of 0, nesting level increased to 1
      201 |         const auto v1 = v0 == 2 ? 0 : v0 + 1;
          |                                 ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:202:33: note: +1, including nesting penalty of 0, nesting level increased to 1
      202 |         const auto v2 = v1 == 2 ? 0 : v1 + 1;
          |                                 ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:220:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      220 |         if( f00 >= 0 )
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:222:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      222 |             if( f01 >= 0 )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:226:13: note: +1, nesting level increased to 2
      226 |             else
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:235:17: note: +3, including nesting penalty of 2, nesting level increased to 3
      235 |                 if( h0 >= 0 )
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:239:17: note: +1, nesting level increased to 3
      239 |                 else
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:242:21: note: +4, including nesting penalty of 3, nesting level increased to 4
      242 |                     if( h1 <= 0 )
          |                     ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:246:21: note: +1, nesting level increased to 4
      246 |                     else
          |                     ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:253:14: note: +1, nesting level increased to 1
      253 |         else if( f01 <= 0 )
          |              ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:255:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      255 |             if( f10 <= 0 )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:260:13: note: +1, nesting level increased to 2
      260 |             else
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:268:17: note: +3, including nesting penalty of 2, nesting level increased to 3
      268 |                 if( h0 >= 0 )
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:272:17: note: +1, nesting level increased to 3
      272 |                 else
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:275:21: note: +4, including nesting penalty of 3, nesting level increased to 4
      275 |                     if( h1 <= 0 )
          |                     ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:279:21: note: +1, nesting level increased to 4
      279 |                     else
          |                     ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:286:14: note: +1, nesting level increased to 1
      286 |         else if( f10 <= 0 )
          |              ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:296:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      296 |             if( h0 >= 0 )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:300:13: note: +1, nesting level increased to 2
      300 |             else
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:303:17: note: +3, including nesting penalty of 2, nesting level increased to 3
      303 |                 if( h1 <= 0 )
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:307:17: note: +1, nesting level increased to 3
      307 |                 else
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:313:9: note: +1, nesting level increased to 1
      313 |         else
          |         ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:321:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      321 |             if( h0 >= 0 )
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:325:13: note: +1, nesting level increased to 2
      325 |             else
          |             ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:328:17: note: +3, including nesting penalty of 2, nesting level increased to 3
      328 |                 if( h1 <= 0 )
          |                 ^
    /__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:332:17: note: +1, nesting level increased to 3
      332 |                 else
          |                 ^
  • src/geode/geometry/distance.cpp:199:30: warning: [readability-identifier-length]

    parameter name 'v0' is too short, expected at least 3 characters

      199 |         geode::local_index_t v0 )
          |                              ^
  • src/geode/geometry/distance.cpp:201:20: warning: [readability-identifier-length]

    variable name 'v1' is too short, expected at least 3 characters

      201 |         const auto v1 = v0 == 2 ? 0 : v0 + 1;
          |                    ^
  • src/geode/geometry/distance.cpp:202:20: warning: [readability-identifier-length]

    variable name 'v2' is too short, expected at least 3 characters

      202 |         const auto v2 = v1 == 2 ? 0 : v1 + 1;
          |                    ^
  • src/geode/geometry/distance.cpp:210:20: warning: [readability-identifier-length]

    variable name 'b0' is too short, expected at least 3 characters

      210 |         const auto b0 = -diff.dot( edge0 );
          |                    ^
  • src/geode/geometry/distance.cpp:211:20: warning: [readability-identifier-length]

    variable name 'b1' is too short, expected at least 3 characters

      211 |         const auto b1 = -diff.dot( edge1 );
          |                    ^
  • src/geode/geometry/distance.cpp:217:9: warning: [cppcoreguidelines-pro-type-member-init]

    uninitialized record type: 'p'

      217 |         std::array< double, 2 > p0, p1, p;
          |         ^
    note: this fix will not be applied because it overlaps with another fix
  • src/geode/geometry/distance.cpp:217:9: warning: [cppcoreguidelines-pro-type-member-init]

    uninitialized record type: 'p0'

    note: this fix will not be applied because it overlaps with another fix
  • src/geode/geometry/distance.cpp:217:9: warning: [cppcoreguidelines-pro-type-member-init]

    uninitialized record type: 'p1'

    note: this fix will not be applied because it overlaps with another fix
  • src/geode/geometry/distance.cpp:217:9: warning: [readability-isolate-declaration]

    multiple declarations in a single statement reduces readability

      217 |         std::array< double, 2 > p0, p1, p;
          |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Have any feedback or feature suggestions? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants