[CHA-4943] Recover from GCP LB TLS half-close EOF - #82
Open
itsmeadi wants to merge 1 commit into
Open
Conversation
OpenSSL 3 makes Net::HTTP's dead-socket probe raise instead of reconnecting. Tolerate unclean shutdown process-wide and restore Faraday's disabled max_retries. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Summary
Follow-up to #78 (
idle_timeout55→25). GCP load balancers half-close idle keep-alive TLS withoutclose_notify. OpenSSL 3 makes Net::HTTP's dead-socket probe raiseSSL_read: unexpected eof while readinginstead of reconnecting, so lowering idle timeout is not enough.Set
OP_IGNORE_UNEXPECTED_EOFso the probe reports a dead socket and reconnects before GET or POST is sent. Restoremax_retries=1(Faraday had forced 0) as a GET/HEAD backstop. Classify that EOF asconnection_reset, nottls_handshake_failed.Previous PR
Checklist
./docs) has been updatedNotes for review
OP_IGNORE_UNEXPECTED_EOFis process-global. Net::HTTP has no per-connection SSLContext options hook. It only relaxes unclean-shutdown detection back to OpenSSL 1.1.1 behavior.http_client:connections skip this (caller owns TLS).Made with Cursor