-
Notifications
You must be signed in to change notification settings - Fork 3
ci: replace the PR-title bump script with release-please #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,139 +1,18 @@ | ||
| name: CI | ||
|
|
||
| # pull_request only. A push trigger alongside it ran the whole suite twice on the same | ||
| # SHA, and the duplicate integration legs raced each other against the Stream app | ||
| # several SDK repos share. The trade is that a merge to master, and a direct push to it, | ||
| # now run nothing: release.yml runs this same workflow only when a release is pending, | ||
| # so the gate before a tag is covered but the routine post-merge signal is gone. | ||
| on: | ||
| push: | ||
| branches: [ master, main ] | ||
| pull_request: | ||
| branches: [ master, main ] | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.head_ref || github.ref_name }} | ||
| cancel-in-progress: true | ||
| branches: [ master, main, '*.x' ] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| unit: | ||
| name: Unit Tests & Code Quality | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: '3.1.0' | ||
|
|
||
| - name: Install dependencies | ||
| run: bundle install --jobs 4 --retry 3 | ||
|
|
||
| - name: Run unit tests | ||
| run: make test | ||
|
|
||
| - name: Run code quality checks | ||
| run: | | ||
| make format-check | ||
| make lint | ||
| make security | ||
|
|
||
| integration-chat: | ||
| name: Chat Integration Tests | ||
| runs-on: ubuntu-latest | ||
| environment: ci | ||
| if: github.event_name == 'push' || github.event_name == 'pull_request' | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: '3.1.0' | ||
|
|
||
| - name: Install dependencies | ||
| run: bundle install --jobs 4 --retry 3 | ||
|
|
||
| - name: Run chat integration tests | ||
| env: | ||
| STREAM_API_KEY: ${{ vars.STREAM_API_KEY }} | ||
| STREAM_API_SECRET: ${{ secrets.STREAM_API_SECRET }} | ||
| STREAM_BASE_URL: ${{ vars.STREAM_BASE_URL }} | ||
| run: make test-integration-chat | ||
|
|
||
| integration-feed: | ||
| name: Feed Integration Tests | ||
| runs-on: ubuntu-latest | ||
| environment: ci | ||
| if: github.event_name == 'push' || github.event_name == 'pull_request' | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: '3.1.0' | ||
|
|
||
| - name: Install dependencies | ||
| run: bundle install --jobs 4 --retry 3 | ||
|
|
||
| - name: Run feed integration tests | ||
| env: | ||
| STREAM_API_KEY: ${{ vars.STREAM_API_KEY }} | ||
| STREAM_API_SECRET: ${{ secrets.STREAM_API_SECRET }} | ||
| STREAM_BASE_URL: ${{ vars.STREAM_BASE_URL }} | ||
| run: make test-integration-feed | ||
|
|
||
| integration-video: | ||
| name: Video Integration Tests | ||
| runs-on: ubuntu-latest | ||
| environment: ci | ||
| if: github.event_name == 'push' || github.event_name == 'pull_request' | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: '3.1.0' | ||
|
|
||
| - name: Install dependencies | ||
| run: bundle install --jobs 4 --retry 3 | ||
|
|
||
| - name: Run video integration tests | ||
| env: | ||
| STREAM_API_KEY: ${{ vars.STREAM_VIDEO_API_KEY }} | ||
| STREAM_API_SECRET: ${{ secrets.STREAM_VIDEO_API_SECRET }} | ||
| STREAM_BASE_URL: ${{ vars.STREAM_VIDEO_BASE_URL }} | ||
| run: make test-integration-video | ||
|
|
||
| integration-gcp-lb: | ||
| name: GCP load balancer keep-alive | ||
| runs-on: ubuntu-latest | ||
| environment: ci | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: '3.1.0' | ||
|
|
||
| - name: Install dependencies | ||
| run: bundle install --jobs 4 --retry 3 | ||
|
|
||
| - name: Run GCP keep-alive integration test | ||
| env: | ||
| STREAM_API_KEY: ${{ vars.STREAM_GCP_API_KEY || vars.STREAM_API_KEY }} | ||
| STREAM_API_SECRET: ${{ secrets.STREAM_GCP_API_SECRET || secrets.STREAM_API_SECRET }} | ||
| STREAM_BASE_URL: ${{ vars.STREAM_GCP_BASE_URL }} | ||
| run: make test-integration-gcp-lb | ||
| tests: | ||
| uses: ./.github/workflows/run_tests.yml | ||
| secrets: inherit | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| name: Lint PR title | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, edited, reopened, synchronize] | ||
|
|
||
| permissions: | ||
| pull-requests: read | ||
|
|
||
| jobs: | ||
| pr_title: | ||
| name: 👮 Conventional PR title | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: amannn/action-semantic-pull-request@v6 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Should Fix] A PR into an
N.xhotfix branch gets no tests at all.This filter is
[ master, main ], so a PR into12.xtriggers nothing.release.ymldoes push-trigger on'*.x', but itstestsjob is gated on a pending release, so the first time a hotfix is tested is the Release PR merge, when the release is already being cut. The README documentsN.xas the supported hotfix path, so this is a live path with no gate.One-line fix:
branches: [ master, main, '*.x' ].Separately, the comment above overstates the master coverage.
release.ymlonly runs the suite when a release is pending, so an ordinary PR merge tomasterand a direct push tomaster(still possible, there is no branch protection) now run nothing. Nothing untested ships, since the Release PR merge is still gated, but the post-merge signal is gone. Worth saying that plainly in the comment rather than "master is covered by release.yml".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both fixed in d886781. The filter is
[ master, main, '*.x' ].The comment now says what is actually true rather than claiming master is covered: