ci: skip the GCP load balancer test on Release PRs too - #90
Merged
Merged
Conversation
This job was left out of the skip on the grounds that it is a keep-alive probe rather than a gate. It is not. spec/integration/gcp_lb_keepalive_spec.rb is an ordinary regression test for CHA-4943: the SDK's connection pool must drop a pooled connection before the GCP SSL proxy closes it at ~30s idle, or the next request raises TransportError. "Keep-alive" there is HTTP connection reuse, not warming anything, and 35 of its 71 seconds are a hardcoded sleep. A Release PR changes no SDK code, so it has nothing to regress. All five test jobs now behave the same, and a Release PR waits on CodeQL alone: 58s rather than 71s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
CHA-5511
Problem
#89 made four of this repo's five test jobs skip on a release-please Release PR.
integration-gcp-lbwas left out on the grounds that it is a keep-alive probe rather than a gate, so skipping it would cost an exercise of the load balancer path.That reasoning was wrong.
spec/integration/gcp_lb_keepalive_spec.rbis an ordinary regression test for CHA-4943:"Keep-alive" is HTTP connection reuse, not warming anything. It tests the SDK's connection-pool idle timeout, 35 of its 71 seconds are a hardcoded
sleep, and a Release PR changes no SDK code.Solution
Give it the same guard the other four jobs carry, and drop the comment that explained the exception.
Result
All five test jobs now behave identically on a Release PR. The wall time drops from 71s to 58s, which is this repo's CodeQL floor and cannot go lower.
How to verify
GCP load balancer keep-aliveshould run as usual.