Fail the build on translations whose placeholders drift - #6696
Draft
gpunto wants to merge 2 commits into
Draft
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Goal
Follow-up to #6695, which fixed a crash on v6 caused by an Italian translation reading
canale% 1$s.Lint reports that as
StringFormatCount, but the check is a warning by default, so./gradlew lintstayed green and the broken string shipped.
Closes AND-1529
Implementation
StringFormatCountto an error for every Android module, in the rootbuild.gradle.ktsnext to the existing shared lint config. A translation whose placeholders drift from the default
locale now fails the build instead of adding a line to a report nobody opens.
%1dspellings still left instream-chat-android-docsand the XML sample,spotted in review on Fix malformed format specifiers in localized strings #6695. Single argument strings, so nothing renders differently.
Scoped to this one check rather than
warningsAsErrors, which would pull in the existing backlog(121 warnings in the Compose module alone).
Testing
./gradlew lintpasses across every module. NoStringFormatfinding exists anywhere today, sothe promotion starts from a clean slate.
full width
%, and confirmed the build now fails on each withStringFormatCount. Reverted after.