ci: drop the redundant post-tag Release PR job - #97
Merged
Merged
Conversation
Added in 30419f4 for a gap that does not exist. The workflow concurrency group already covers it: a push during a release run goes pending rather than running, and starts only once the tag exists and the label has flipped, so its own detect reports no pending release and release-pr runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
release-pr-followup, added in30419f4(#96), fixes a gap that does not exist. The reasoning behind it was wrong: it assumed a push landing during a release run executes and skipsrelease-pr, stranding that commit until the next unrelated push.It does not execute. The workflow-level
concurrencygroup (release-${{ github.ref_name }},cancel-in-progress: false) makes that run pending. It starts only after the release run ends, by which point release-please has tagged and flipped the merged Release PR toautorelease: tagged, so its owndetectreportspending=falseandrelease-propens the Release PR normally. Where several pushes queue, GitHub keeps the newest pending run, and release-please walks history, so the survivor still proposes every commit that landed in the window.Solution
Remove the job.
detect's gate is still load-bearing for the two cases that do reach it: the release run itself, and a run following a release that failed after its Release PR merged.How to verify
Releaseon the next push tomainrunsDetect pending release→Release PRand nothing else, as it did before #96 added the job.