feat: Add PSC DNS and Global Write Endpoint support to Python Connector - #1446
Open
hessjcg wants to merge 1 commit into
Open
feat: Add PSC DNS and Global Write Endpoint support to Python Connector#1446hessjcg wants to merge 1 commit into
hessjcg wants to merge 1 commit into
Conversation
- Implement transient vs non-transient error detection in MonitoredCache. - Detect immutable instance DNS names using the corrected regex. - Avoid checking error message strings by using custom exception type (DnsLoopError). Address review comments: - kgala2: 'Should we have a try catch block of this sort to have a graceful shut in case of transient failures?' - hessjcg: 'Use an error code. Don'\''t check error message strings.' - hessjcg: 'The correct logic for detecting an immutable instance dns name: IF name matches /\.sql(-\w+)?\.goog$/ AND name does not match /\.global\.sql(-\w+)?\.goog$/'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds PSC DNS support to the Python connector, including recent fixes for error handling: