Skip to content

Vertex ai reasoning engine buildspec service account - #18697

Merged
melinath merged 4 commits into
GoogleCloudPlatform:mainfrom
melinath:vertex-ai-reasoning-engine-buildspec-service-account
Aug 25, 2026
Merged

Vertex ai reasoning engine buildspec service account#18697
melinath merged 4 commits into
GoogleCloudPlatform:mainfrom
melinath:vertex-ai-reasoning-engine-buildspec-service-account

Conversation

@melinath

Copy link
Copy Markdown
Member

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

vertexai: added spec.build_spec.service_account field to google_vertex_ai_reasoning_engine 

@modular-magician

modular-magician commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 368fdcd:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 54 insertions(+)
google-beta provider View Diff 4 files changed, 77 insertions(+)
terraform-google-conversion View Diff 1 file changed, 11 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
113 104 7 2
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ❌ Error · Log TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@melinath VCR tests complete for 368fdcd!

@modular-magician

modular-magician commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8356c5a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 12 insertions(+)
google-beta provider View Diff 4 files changed, 35 insertions(+)
terraform-google-conversion View Diff 1 file changed, 11 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
113 104 7 2
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@melinath VCR tests complete for 8356c5a!

@melinath

Copy link
Copy Markdown
Member Author

@modular-magician reassign-reviewer @slevenick

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from slevenick August 19, 2026 21:38
@melinath
melinath added this pull request to the merge queue Aug 25, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 454c977 Aug 25, 2026
28 of 29 checks passed
@melinath
melinath deleted the vertex-ai-reasoning-engine-buildspec-service-account branch August 25, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants