fix(genai): ensure resource cleanup and fix async execution in content-cache tests - #4403
Open
angelcaamal wants to merge 2 commits into
Open
fix(genai): ensure resource cleanup and fix async execution in content-cache tests#4403angelcaamal wants to merge 2 commits into
angelcaamal wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the content-cache-create-use-update-delete.test.js test suite by removing the async keyword from the describe block, moving the initial delay into a before hook, and adding an after hook to ensure the content cache is cleaned up. Feedback was provided pointing out that using a before hook for the retry delay will only run once and won't execute on test retries. It is recommended to use a beforeEach hook with this.currentTest instead.
angelcaamal
marked this pull request as ready for review
August 18, 2026 16:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes several execution and lifecycle issues in the
genai/content-cachetests.Previously, the tests had the following issues:
describeblock was marked asasync, which is not supported by Mocha and caused the suite to exit early or register0 passingtests.beforehook. Sincebeforeonly runs once per suite, test retries were not getting the intended backoff delay.Fixes Internal: b/548501421
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.