Skip to content

chore(genai): update dependencies for count-tokens, safety, live, embeddings, and related samples - #4405

Open
angelcaamal wants to merge 2 commits into
mainfrom
chore-update-genai-dependencies
Open

chore(genai): update dependencies for count-tokens, safety, live, embeddings, and related samples#4405
angelcaamal wants to merge 2 commits into
mainfrom
chore-update-genai-dependencies

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes Internal: b7548033568
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Aug 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @google/genai dependency and devDependencies (c8 and chai) across multiple package.json files. The reviewer identified that the @google/genai dependency version was inconsistently updated to 2.17.0 instead of 2.17.1 in genai/embeddings/package.json and genai/express-mode/package.json, and provided suggestions to align them with the other packages.

Comment thread genai/embeddings/package.json Outdated
Comment thread genai/express-mode/package.json Outdated

@XrossFox XrossFox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelcaamal
angelcaamal marked this pull request as ready for review August 18, 2026 21:38
@angelcaamal
angelcaamal requested review from a team as code owners August 18, 2026 21:38
@angelcaamal angelcaamal changed the title chore(genai): update package dependencies across multiple samples chore(genai): update dependencies for count-tokens, safety, live, embeddings, and related samples Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants