Skip to content

chore(genai): update package dependencies in text, tools, tuning and video samples - #4406

Open
angelcaamal wants to merge 1 commit into
mainfrom
chore-update-genai-text-tools-deps
Open

chore(genai): update package dependencies in text, tools, tuning and video samples#4406
angelcaamal wants to merge 1 commit into
mainfrom
chore-update-genai-text-tools-deps

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes Internal: b/548037346

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Aug 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependencies across several package.json files, including upgrading @google/genai to 2.17.1, c8 to ^12.0.0, and chai to ^6.0.0. The reviewer correctly identified that upgrading chai to ^6.0.0 will break the test suites because Chai v5+ is ESM-only, while this project relies on CommonJS. It is recommended to revert the chai upgrades to ^4.5.0 to prevent ERR_REQUIRE_ESM errors.

Comment thread genai/package.json
Comment thread genai/text-generation/package.json
Comment thread genai/thinking/package.json
Comment thread genai/tools/package.json
Comment thread genai/tuning/package.json
Comment thread genai/video-generation/package.json

@XrossFox XrossFox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelcaamal
angelcaamal marked this pull request as ready for review August 18, 2026 22:41
@angelcaamal
angelcaamal requested review from a team as code owners August 18, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants