Skip to content

Add functional tests for non-jar exclude and custom r8 args - #2295

Merged
Goooler merged 3 commits into
mainfrom
g/20260909/add-tests
Sep 9, 2026
Merged

Add functional tests for non-jar exclude and custom r8 args#2295
Goooler merged 3 commits into
mainfrom
g/20260909/add-tests

Conversation

@Goooler

@Goooler Goooler commented Sep 9, 2026

Copy link
Copy Markdown
Member

Refs #2293.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new passCustomR8Args functional test’s expectations don’t match Shadow’s default R8 behavior and are likely incorrect/flaky without adjustment.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds functional-test coverage for two edge cases in Shadow’s functional test suite: excluding a transitive dependency that has no JAR artifact (POM-only), and configuring custom R8 command-line arguments during minimization.

Changes:

  • Extend the functional-test Maven repo builder to publish POM-only modules (pomModule / PomModule).
  • Add a Filtering functional test that excludes a transitive POM-only dependency.
  • Add an R8 minimization functional test intended to validate custom R8 args handling (currently with an assertion that should be adjusted; see review comment).
File summaries
File Description
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenRepository.kt Adds support for publishing POM-only modules in the test Maven repository.
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/BasePluginTest.kt Extends the shared local Maven repo fixture with a module that depends on a POM-only dependency.
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/FilteringTest.kt Adds a test that applies an exclude rule targeting a transitive POM-only dependency.
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/R8MinimizationTest.kt Adds a test for custom R8 args (needs a deterministic assertion to avoid flakiness).
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Goooler
Goooler force-pushed the g/20260909/add-tests branch from 318527e to 3361065 Compare September 9, 2026 09:58
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Goooler
Goooler force-pushed the g/20260909/add-tests branch from f40f99b to 5a018f0 Compare September 9, 2026 10:00
@Goooler
Goooler enabled auto-merge (squash) September 9, 2026 10:05
@Goooler
Goooler merged commit ef8d9fb into main Sep 9, 2026
6 checks passed
@Goooler
Goooler deleted the g/20260909/add-tests branch September 9, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants